Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard should reuse Che Server functionality for devfile v1 overrides #19424

Closed
themr0c opened this issue Mar 26, 2021 · 1 comment · Fixed by eclipse-che/che-dashboard#219
Assignees
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone

Comments

@themr0c
Copy link
Contributor

themr0c commented Mar 26, 2021

Following docs at: https://www.eclipse.org/che/docs/che-7/end-user-guide/creating-a-workspace-from-remote-devfile/#overriding-devfile-values-using-factory-parameters_che

I adapted the example to have a clickable example:

https:///f?url=https://github.com/maxandersen/quarkus-quickstarts/tree/che&override.projects.quarkus-quickstarts.source.branch=1.0.x

But the branch was not adapted:

apiVersion: 1.0.0
metadata:
  name: quarkus-quickstarts-spuc5
projects:
  - name: quarkus-quickstarts
    source:
      location: 'https://github.com/maxandersen/quarkus-quickstarts.git'
      type: github
      branch: che

Update:
It's caused by fact that a new Dashboard merge devfile on client side, which does not handle several cases:

  • dots in attribute name;
  • matching objects in arrays with name/id, like projects..source.branch
@themr0c themr0c added the kind/bug Outline of a bug - must adhere to the bug report template. label Mar 26, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 26, 2021
@yhontyk yhontyk added area/devfile/v1 severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 26, 2021
@sleshchenko
Copy link
Member

Good catch!

It as two issues:

  1. New dashboard tries to apply overrides on its side, when it just needs to pass params to Che Server, like
    Screenshot_20210401_120442

  2. It's not possible to specify branch with overrides if repo does not have devfile inside Error is thrown when try to specify branch in factory url for repo without devfile #19479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants