Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CheCluster v2alpha1 as devworkspace che configuration #19448

Closed
5 tasks
metlos opened this issue Mar 29, 2021 · 1 comment
Closed
5 tasks

Use CheCluster v2alpha1 as devworkspace che configuration #19448

metlos opened this issue Mar 29, 2021 · 1 comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@metlos
Copy link
Contributor

metlos commented Mar 29, 2021

We need to use conversion webhooks and start storing a v2alpha1 version of the CheCluster that would have the old che7 configuration stashed under spec.che7 and devworkspace config properties directly under spec. This way, the che operator and devworkspace che operator could react to this new version and one would just read the spec from under che7 and continue normally as we do at the moment and the other would read the dw configuration and apply it to devworkspaces.

Disallowing more instances of CheCluster is a matter of checking the cluster state during reconciliation.

This needs to be implemented in the following order:

@metlos metlos added kind/enhancement A feature request - must adhere to the feature request template. engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. labels Mar 29, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 29, 2021
@metlos metlos changed the title Create CheCluster v2alpha1 for devworkspace che Use CheCluster v2alpha1 as devworkspace che configuration Mar 29, 2021
@mshaposhnik mshaposhnik added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 30, 2021
@metlos metlos added the area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator label Mar 30, 2021
@metlos
Copy link
Contributor Author

metlos commented May 21, 2021

This is superseded by #19845. Once we get to the point where we need to define the new CR version, we can revisit this issue or create a new one.

@metlos metlos closed this as completed May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants