Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWCO release process broken #19526

Closed
3 tasks done
nickboldt opened this issue Apr 7, 2021 · 3 comments
Closed
3 tasks done

DWCO release process broken #19526

nickboldt opened this issue Apr 7, 2021 · 3 comments
Assignees
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@nickboldt
Copy link
Contributor

nickboldt commented Apr 7, 2021

Describe the bug

Some problems:

  • 1. che-release process does not have admin rights to che-incubator/devworkspace-che-operator to run actions.
{
  "message": "Must have admin rights to Repository.",
  "documentation_url": "https://docs.github.com/rest/reference/actions#create-a-workflow-dispatch-event"
}
[INFO] Invoked 'Release DevWorkspace Che Operator' action (6597719) - see https://github.com/che-incubator/devworkspace-che-operator/actions?query=workflow%3A%22Release+DevWorkspace+Che+Operator%22
  • 2. release GH action is pushing to :ci tag, but not creating a v7.yy.z tag too:

https://github.com/che-incubator/devworkspace-che-operator/actions/workflows/release.yml?query=workflow%3A%22Release+DevWorkspace+Che+Operator%22
https://quay.io/repository/che-incubator/devworkspace-che-operator?tag=latest&tab=tags

image

This means that phase 4 of the che-release will never be successful as we'll never get success here:

[__/90] Verify quay.io/che-incubator/devworkspace-che-operator:7.28.2 exists...
  • 3. It's unclear who has admin rights to the quay repo - should be the usual creators, owners, and bots, so that both Nick and Mykhailo can adminster the repo.
@nickboldt nickboldt added the kind/bug Outline of a bug - must adhere to the bug report template. label Apr 7, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 7, 2021
@nickboldt
Copy link
Contributor Author

nickboldt commented Apr 7, 2021

Item # 2 should be fixed with che-incubator/devworkspace-che-operator#35

verified https://quay.io/repository/che-incubator/devworkspace-che-operator?tab=tags has a v7.28.2 release now, but it's single arch so we'll want to eventually make that multiarch (like the ci builds)

Any suggestions for how to fix items # 1 and # 3 ?

@nickboldt nickboldt added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Apr 7, 2021
@benoitf benoitf added engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. area/ci CI build and releases, PR testing, & whitelabel/productization issues labels Apr 7, 2021
@mkuznyetsov mkuznyetsov mentioned this issue Apr 7, 2021
15 tasks
@nickboldt
Copy link
Contributor Author

nickboldt commented Apr 8, 2021

Seems permissions are fixed, so item # 1 is done.

Can't confirm # 2 is fixed because of this new issue when building, problem # 4:

We have BOTH
https://github.com/devfile/devworkspace-operator/blob/v0.2.2/version/version.go (1.0.0-next)
and
https://github.com/devfile/devworkspace-operator/blob/v0.2.2/VERSION (v0.2.2)

and so when you try to load https://sum.golang.org/lookup/github.com/devfile/devworkspace-operator@v0.2.2 you get

not found: create zip: version/version.go: case-insensitive file name collision: "VERSION" and "version"

thus the build fails:
https://github.com/che-incubator/devworkspace-che-operator/runs/2295636017?check_suite_focus=true (edited)

This begs two questions:

  • Why do we have a version.go that's not the same as the tag?
  • Why do we define a VERSION file at all, if there's a version.go?
  • Why do we need any versioning if the release tags the code and can therefore be seen as the version itself (tag v0.2.2) ?
  • Why can't I count to two?

@nickboldt
Copy link
Contributor Author

Also fixed a bug in che-release eclipse-che/che-release@46bcb01 so that the quay container check will pass :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants