Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[che-auth] - enable nativeUserMode by default on openshift with devworkspaces #20203

Closed
Tracked by #19182 ...
sparkoo opened this issue Jul 27, 2021 · 4 comments
Closed
Tracked by #19182 ...
Assignees
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@sparkoo
Copy link
Member

sparkoo commented Jul 27, 2021

Is your task related to a problem? Please describe.

Since we do not have any known blocker regression in nativeUserMode way of auth, we would like to enable it by default to gather feedback as soon as possible.

known issues:

Describe the solution you'd like

Set auth.nativeUserMode: true by default when deploying on openshift with devworkspace engine.

Describe alternatives you've considered

Keep it optional

Additional context

epic: #19182

@sparkoo sparkoo added kind/task Internal things, technical debt, and to-do tasks to be performed. team/platform area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Jul 27, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 27, 2021
@vzhukovs vzhukovs removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 27, 2021
@sparkoo sparkoo self-assigned this Jul 28, 2021
@sleshchenko
Copy link
Member

Actually, there is one user-facing change after we make it as default - it won't be possible to open Che Workspaces when DevWorkspace is enabled. So, let's discuss it again on the next devworkspace cabal.

@skabashnyuk
Copy link
Contributor

skabashnyuk commented Jul 29, 2021

Actually, there is one user-facing change after we make it as default - it won't be possible to open Che Workspaces when DevWorkspace is enabled.

it would not change much since it wasn't declared as possible before.
Is there an alternative plan have we can make devworkspace production-ready except start enabling necessary features like authentication one by one?

@sparkoo
Copy link
Member Author

sparkoo commented Jul 30, 2021

At the moment, Che Workspaces does not work with devworkspaces (#20072). I assume it's "easy" fix, but still...

Then the question is, whether devworkspaces without authentication are really usable. I guess we can go 2 ways:

  • live with unsecure dev-workspaces and working che-workspaces and switch default only after both is working
  • switch default now and live with not-working che-workspaces and secure dev-workspaces, and start working on making che-workspaces with new auth (or not)

note that dev-workspaces are not authenticated yet with nativeUserMode, but we plan to work on it this sprint #19707

Anyway, I'm now only creating draft PR to this, because I still have few open technical questions there. I'll raise a topic on dw cabal.

@sparkoo
Copy link
Member Author

sparkoo commented Aug 6, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

5 participants