Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UD] Setup formatter and linter for the dashboard backend #20379

Closed
akurinnoy opened this issue Aug 30, 2021 · 1 comment · Fixed by eclipse-che/che-dashboard#361
Closed

[UD] Setup formatter and linter for the dashboard backend #20379

akurinnoy opened this issue Aug 30, 2021 · 1 comment · Fixed by eclipse-che/che-dashboard#361
Assignees
@akurinnoy
Labels
area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/current
Milestone
7.37

Comments

@akurinnoy
Copy link
Contributor

Is your task related to a problem? Please describe

The dashboard backend package doesn't have any formatter set up and only contains the configuration file for tslint that was deprecated some time ago.

Describe the solution you'd like

Setup typescript formatter and eslint for the dashboard backend package; reuse configurations from the dashboard frontend package. Run linter and formatter for staged files on pre-commit hook.

Describe alternatives you've considered

No response

Additional context

No response
@akurinnoy akurinnoy added kind/task Internal things, technical debt, and to-do tasks to be performed. area/dashboard team/controller labels Aug 30, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 30, 2021
@akurinnoy akurinnoy added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 30, 2021
@sleshchenko sleshchenko mentioned this issue Sep 6, 2021
Closed
@sleshchenko sleshchenko added this to the 7.37 milestone Sep 9, 2021
@sleshchenko sleshchenko mentioned this issue Sep 9, 2021
Closed
@sleshchenko sleshchenko mentioned this issue Sep 24, 2021
Merged
@sleshchenko
Copy link
Member

fixed by eclipse-che/che-dashboard#361

@akurinnoy akurinnoy mentioned this issue Sep 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akurinnoy akurinnoy

Labels
area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/current
Projects
None yet
Milestone
7.37
Development

Successfully merging a pull request may close this issue.

Configure eslint and tsfmt for all packages eclipse-che/che-dashboard
3 participants
@sleshchenko @akurinnoy @che-bot