Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory limit/Memory request for traefik that is running as a part of workspace #20520

Closed
Tracked by #20444
skabashnyuk opened this issue Sep 23, 2021 · 5 comments
Closed
Tracked by #20444
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/next

Comments

@skabashnyuk
Copy link
Contributor

Is your task related to a problem? Please describe

In this issue #20190 we introduce traefik as a part of workspace pod to secure services. Now memory limit/request is not set and used the system default

Describe the solution you'd like

Set reasonable memory limit/Memory request for traefik that is running as a part of the workspace

Describe alternatives you've considered

No response

Additional context

No response

@skabashnyuk skabashnyuk added kind/task Internal things, technical debt, and to-do tasks to be performed. area/devworkspace-che-operator sprint/next labels Sep 23, 2021
@sparkoo sparkoo self-assigned this Sep 23, 2021
@sparkoo
Copy link
Member

sparkoo commented Sep 23, 2021

here's the traefik podaddition https://github.com/eclipse-che/che-operator/blob/main/controllers/devworkspace/solver/che_routing.go#L162 I've also noticed there is ImagePullPolicy: corev1.PullAlways, which does not make much sense to pull it on every workspace startup

@sparkoo
Copy link
Member

sparkoo commented Sep 23, 2021

should we also set CPU L/R?

@benoitf
Copy link
Contributor

benoitf commented Sep 23, 2021

yes for CPU limit/request
we had cases where these limits were not defined and then default were either too low or too high and workspace was not running smoothly

@mshaposhnik
Copy link
Contributor

mshaposhnik commented Sep 23, 2021

so what's the proposal? 64 / 256 Mb on RAM and 0.05 / 0.5 CPU? Enough?

@sparkoo
Copy link
Member

sparkoo commented Sep 23, 2021

so what's the proposal? 64 / 256 Mb on RAM and 0.05 / 0.5 CPU? Enough?

looks reasonable to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/next
Projects
None yet
Development

No branches or pull requests

4 participants