Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable resource limits for devworkspaces #20527

Closed
metlos opened this issue Sep 23, 2021 · 3 comments
Closed

Configurable resource limits for devworkspaces #20527

metlos opened this issue Sep 23, 2021 · 3 comments
Labels
area/devworkspace-operator kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.

Comments

@metlos
Copy link
Contributor

metlos commented Sep 23, 2021

Is your enhancement related to a problem? Please describe

Currently, the devworkspace-operator (DWO) sets the default CPU and memory limit unconditionally to a certain value (64M/128M for memory request/limit and no defaults for CPU, leaving them to the cluster defaults).

Che server can be configured with custom default memory and cpu requests/limits.

Describe the solution you'd like

We should enable this functionality also for the devworkspaces. This would probably be implemented as a new property in CheCluster custom resource (both v1 and v2alpha1).

Describe alternatives you've considered

No response

Additional context

No response

@metlos metlos added the kind/enhancement A feature request - must adhere to the feature request template. label Sep 23, 2021
@benoitf benoitf added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 23, 2021
@dmytro-ndp dmytro-ndp added severity/P1 Has a major impact to usage or development of the system. area/devworkspace-operator team/controller and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 23, 2021
@l0rd
Copy link
Contributor

l0rd commented Sep 27, 2021

For clarity: you are talking about the cpu/mem limits/requests of workspaces containers or about those of the operator controller?

@l0rd
Copy link
Contributor

l0rd commented Sep 27, 2021

Note that:

  • users are able and encouraged to specify cpu/mem limits/requests for the components in their devfiles. Configuring Che that to automatically set a defaul value is a source of errors and eventually non starting workspaces.
  • an admin can always set the default cpu/mem limits of the workspace containers configuring namespaces LimitRange

That said I think that this issue should consist in making sure that:

  • cpu/mem limits/requests of all our plugins/editors should be explicitly specified in the plugin registry
  • cpu/mem limits/requests of all our samples components should be explicitly specified in the corresponding devfiles
  • there are containers that a user doesn't control (workspaces traefik, init containers, ...): for those containers only we should have CheCluster fields to make the values configurable.

@che-bot
Copy link
Contributor

che-bot commented May 10, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 10, 2022
@che-bot che-bot closed this as completed May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devworkspace-operator kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants