Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom certificates for git hosts for devworkspaces #20528

Closed
Tracked by #20830
metlos opened this issue Sep 23, 2021 · 6 comments
Closed
Tracked by #20830

Support custom certificates for git hosts for devworkspaces #20528

metlos opened this issue Sep 23, 2021 · 6 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@metlos
Copy link
Contributor

metlos commented Sep 23, 2021

Is your enhancement related to a problem? Please describe

Che server supports custom certificates for the git servers that it uses to create the gitconfig file in the workspace pod. This feature seems to be missing in devworkspace-operator.

Describe the solution you'd like

Che server currently supports only a single custom git credentials, while DWO supports multiple. Therefore we need to be careful and design this differently in DWO.

Describe alternatives you've considered

No response

Additional context

https://github.com/eclipse-che/che-server/blob/d1c3570fca85807edb4528fce2f346a23ee66d35/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/provision/GitConfigProvisioner.java#L206

devfile/devworkspace-operator#613

@metlos metlos added the kind/enhancement A feature request - must adhere to the feature request template. label Sep 23, 2021
@benoitf benoitf added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 23, 2021
@dmytro-ndp dmytro-ndp added area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator severity/P2 Has a minor but important impact to the usage or development of the system. team/controller area/devworkspace-operator and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Sep 23, 2021
@skabashnyuk skabashnyuk added area/devworkspace-che-operator and removed area/devworkspace-operator team/controller severity/P2 Has a minor but important impact to the usage or development of the system. labels Sep 24, 2021
@sleshchenko
Copy link
Member

Note that DWO has mechanism for generating gitconfig that currently taking into account only git credentials with personal access tokens devfile/devworkspace-operator#564

@l0rd
Copy link
Contributor

l0rd commented Sep 28, 2021

This is the CheCluster side issue of devfile/devworkspace-operator#613. An admin should be able to specify custom certificates for git hosts in the CheCluster CR.

@l0rd
Copy link
Contributor

l0rd commented Nov 11, 2021

@metlos @skabashnyuk is someone working on this?

@skabashnyuk
Copy link
Contributor

No

@gazarenkov
Copy link
Contributor

gazarenkov commented Nov 22, 2021

Should it be fixed by devfile/devworkspace-operator#613 on DWO first or they are independent from each other?

@metlos
Copy link
Contributor Author

metlos commented Nov 22, 2021

To use CheCluster CR for configuring DevWorkspaces, we first need support for this feature in DWO. Once DWO can use the certificates in gitconfig, we can then update our usernamespace controller that transforms the configuration in CheCluster CR into configuration within the user's namespace where it can be picked up by DWO.

Updating the usernamespace controller should not be hard, but we first need to know what "format" DWO will use for this. The names of labels used, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

7 participants