Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use image pull secrets stored as credentials in user preferences of Che-server in DevWorkspaces #20534

Closed
Tracked by #20168
metlos opened this issue Sep 24, 2021 · 1 comment
Labels
area/che-server kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@metlos
Copy link
Contributor

metlos commented Sep 24, 2021

Is your enhancement related to a problem? Please describe

Che-server supports storing docker config json in dockerCredentials user preference. It is then able to create secret with this configuration and mount it as a image pull secret of workspace pods.

Devworkspace operator is able to mount labeled secrets as image pull secrets of the workspace pod.

Describe the solution you'd like

Che server should synchronize the docker config stored in user prefs as a secret in the user's namespace with the correct labels so that it is picked up by DWO.

Describe alternatives you've considered

No response

Additional context

No response

@metlos metlos added the kind/enhancement A feature request - must adhere to the feature request template. label Sep 24, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 24, 2021
@l0rd l0rd added area/che-server severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 27, 2021
@l0rd
Copy link
Contributor

l0rd commented Sep 28, 2021

As mentioned yesterday this issue should not be addressed on che-server side because the credentials are per user and should not be managed by the che-sever. It's something that should be changed at dashboard side and part of #17954

@l0rd l0rd closed this as completed Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-server kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants