Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support v2.2 Devfiles #20850

Closed
1 of 2 tasks
l0rd opened this issue Nov 30, 2021 · 6 comments
Closed
1 of 2 tasks

Support v2.2 Devfiles #20850

l0rd opened this issue Nov 30, 2021 · 6 comments
Labels
area/devfile-spec Issues related to Devfile v2 area/devworkspace-operator kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Nov 30, 2021 •
edited
Loading

Is your enhancement related to a problem? Please describe

The OpenShift Developer Console will include some new examples that have Devfiles withouth placeholder outerloop component. But those Devfiles will use v2.2 of the spec.

Trying to start a workspace from this repo https://github.com/devfile-samples/devfile-sample-java-springboot-basic, on che next with devworkspace enabled, I faced the following problems:

  1. Components of type image is considered invalid
  2. Command build-image references the component of type image that is not supported
  3. Commands of type composite are not supported
  4. mvn commands fail because the default workingDir is /projects
  5. (Related but not a problem with the devfile above): special variable $PROJECT_SOURCE is not supported

Describe the solution you'd like

  • When DevWorkspace is enabled:
  1. DevWorkspace supports image components ignoring them
  2. DevWorkspace ignores commands associated to image components
  3. DevWorkspace supports composite commands
  4. DevWorkspace sets default working directory to first project folder (not /projects/)
  5. DevWorkspace supports PROJECT_SOURCE (not PROJECTS_SOURCE)
  6. DevWorkspace ignores placeholder outerloop component
  1. Devfile converter removes any image components during conversion
  2. Devfile converter removes commands associated to image components
  3. Devfile converter removes composite commands
  4. Devfile converter sets default working directory to first project folder (not /projects/)
  5. Devfile converter replaces PROJECT_SOURCE with the path to the first project /projects/
  6. Devfile converter removes placeholder outerloop component
@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Nov 30, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 30, 2021
@l0rd l0rd added area/devfile-spec Issues related to Devfile v2 area/devworkspace-operator severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 30, 2021
@benoitf benoitf mentioned this issue Dec 1, 2021
Closed
@l0rd l0rd added the area/devfile-converter library used to convert v1 to v2 or v2 to v1 devfiles label Dec 1, 2021
@l0rd
Copy link
Contributor Author

l0rd commented Dec 2, 2021

Created this PR devfile-samples/devfile-sample-java-springboot-basic#2 to fix some issues with https://github.com/devfile-samples/devfile-sample-java-springboot-basic

@benoitf benoitf mentioned this issue Dec 3, 2021
Merged
9 tasks
@amisevsk
Copy link
Contributor

amisevsk commented Dec 3, 2021

One issue that has to be resolved first is that currently devfile/api versions have removed v1alpha1 DevWorkspaces. However, there are still some users of DevWorkspaces that depend on this API version, so DWO must continue to ship conversion webhooks for the time being. We need to consider reverting devfile/api#639

@benoitf
Copy link
Contributor

benoitf commented Dec 6, 2021

part of che-server workspaces has been implemented and merged

@l0rd l0rd mentioned this issue Dec 7, 2021
Merged
@benoitf benoitf removed the area/devfile-converter library used to convert v1 to v2 or v2 to v1 devfiles label Dec 13, 2021
@benoitf
Copy link
Contributor

benoitf commented Dec 13, 2021

removed area/devfile-converter as this action has been done

@l0rd l0rd mentioned this issue Feb 20, 2022
Closed
9 tasks
@che-bot
Copy link
Contributor

che-bot commented Jun 11, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 11, 2022
@l0rd l0rd removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 13, 2022
@che-bot
Copy link
Contributor

che-bot commented Dec 10, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 10, 2022
@che-bot che-bot closed this as completed Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/devfile-spec Issues related to Devfile v2 area/devworkspace-operator kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@benoitf @l0rd @amisevsk @che-bot