Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure devworkspace namespace with user name and email in gitconfig #20871

Closed
Tracked by #20830
metlos opened this issue Dec 2, 2021 · 3 comments
Closed
Tracked by #20830

Configure devworkspace namespace with user name and email in gitconfig #20871

metlos opened this issue Dec 2, 2021 · 3 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@metlos
Copy link
Contributor

metlos commented Dec 2, 2021

Is your enhancement related to a problem? Please describe

Che server supports storing the user's name and email in the gitconfig mounted to the Che7 workspaces. This is currently not possible for devworkspaces because devworkspace operator doesn't support this.

Describe the solution you'd like

Once support for this lands in DWO, we should decide how to implement this in Che. We can either simply take the user name and email from the database record as we do now for che7 workspaces or we can take advantage of the che.eclipse.org/workspace-namespace-owner-uid that is required on che-targetted namespaces and draw the information from there directly.

Describe alternatives you've considered

No response

Additional context

There is an issue for implementing this on the DWO side: devfile/devworkspace-operator#694

@metlos metlos added the kind/enhancement A feature request - must adhere to the feature request template. label Dec 2, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 2, 2021
@themr0c themr0c added severity/P1 Has a major impact to usage or development of the system. and removed severity/P1 Has a major impact to usage or development of the system. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 3, 2021
@ibuziuk
Copy link
Member

ibuziuk commented Dec 6, 2021

We can either simply take the user name and email from the database record

my understanding that the vision is that database will cease to exist in the future releases, so probably this is not the best option to consider

@ibuziuk
Copy link
Member

ibuziuk commented Dec 13, 2021

@metlos another reason not to fall back on db - eclipse-che/che-docs#2159 (comment)

@skabashnyuk
Copy link
Contributor

Closing in favor of #20937 and #20938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants