Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting a workspace from a repository without devfile is not adding/cloning the project #20893

Closed
benoitf opened this issue Dec 7, 2021 · 6 comments · Fixed by eclipse-che/che-dashboard#420
Labels
area/dashboard engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@benoitf
Copy link
Contributor

benoitf commented Dec 7, 2021

Describe the bug

Starts with the link http://che-server#https://github.com/spring-projects/spring-petclinic on a DevWorkspaces enabled che instance

I expect to see spring-petclinic sample being cloned

I've only Theia that is started.

8j5csV35Ov.mp4

Che version

next (development version)

Steps to reproduce

Click on http://che-server#https://github.com/spring-projects/spring-petclinic

project is not added by Dashboard

Expected behavior

project is being cloned

Runtime

OpenShift, other (please specify in additional context)

Screenshots

No response

Installation method

chectl/next

Environment

other (please specify in additional context)

Eclipse Che Logs

No response

Additional context

No response

@benoitf benoitf added kind/bug Outline of a bug - must adhere to the bug report template. area/dashboard engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. labels Dec 7, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 7, 2021
@skabashnyuk
Copy link
Contributor

are you able to clone the project manually from Theia?

@benoitf
Copy link
Contributor Author

benoitf commented Dec 7, 2021

@skabashnyuk yes

Also resolver API returns

{
  "v": "4.0",
  "source": "repo",
  "devfile": {
    "metadata": {
      "generateName": "spring-petclinic"
    },
    "projects": [
      {
        "name": "spring-petclinic",
        "source": {
          "location": "https://github.com/spring-projects/spring-petclinic.git",
          "type": "github"
        }
      }
    ],
    "apiVersion": "1.0.0"
  }
}

but projects section is empty in my DevWorkspace

@benoitf
Copy link
Contributor Author

benoitf commented Dec 7, 2021

And the clone is done by project-clone init container but as there is no projects section in the devfile it does nothing as well.

@sparkoo sparkoo added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 7, 2021
@l0rd
Copy link
Contributor

l0rd commented Dec 15, 2021

@ibuziuk @benoitf could you provide the link to the PR that should fix this issue?

@ibuziuk
Copy link
Member

ibuziuk commented Dec 15, 2021

@akurinnoy could you please confirm that eclipse-che/che-dashboard#420 should also fix this problem?

@akurinnoy
Copy link
Contributor

yes, that PR will fix this issue as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants