Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevWorkspace] Mount SSH secret to all workspace containers #20975

Closed
vinokurig opened this issue Dec 30, 2021 · 1 comment
Closed

[DevWorkspace] Mount SSH secret to all workspace containers #20975

vinokurig opened this issue Dec 30, 2021 · 1 comment
Labels
area/che-server kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@vinokurig
Copy link
Contributor

Is your task related to a problem? Please describe

Che-server mounts SSH keys stored in the postgres to all workspace containers, see. Also it creates a predefined SSH key if no SSH keys are stored in the database, and then mounts it to the workspace containers.
Need to apply the same logic for the DevWorkspace engine. We already have the workspace-credentials-secret which is expected to store SSH keys, so we don't need to read the database, just mount the existing secret.

Describe the solution you'd like

Implement the logic in the DevWorkspce Operator.

Describe alternatives you've considered

No response

Additional context

No response

@vinokurig vinokurig added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Dec 30, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 30, 2021
@ibuziuk
Copy link
Member

ibuziuk commented Dec 30, 2021

@vinokurig the ssh story has been finalized as part of the #20832
Could you clarify what exactly is missing?

@Kasturi1820 Kasturi1820 added area/che-server team/platform severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-server kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants