Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-registry-generator] Improve plugin registry generator #21072

Closed
svor opened this issue Jan 25, 2022 · 0 comments
Closed

[plugin-registry-generator] Improve plugin registry generator #21072

svor opened this issue Jan 25, 2022 · 0 comments
Assignees
Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@svor
Copy link
Contributor

svor commented Jan 25, 2022

Is your task related to a problem? Please describe

For now if execute plugin-registry-generator tool in the folder which is not a git repository, it will fail with error:

stack=Error: fatal: not a git repository (or any parent up to mount point /home)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

    at Object.action (/home/vsvydenko/.npm/_npx/292135/lib/node_modules/@eclipse-che/plugin-registry-generator/node_modules/simple-git/src/lib/plugins/error-detection.plugin.js:30:33)
    at PluginStore.exec (/home/vsvydenko/.npm/_npx/292135/lib/node_modules/@eclipse-che/plugin-registry-generator/node_modules/simple-git/src/lib/plugins/plugin-store.js:21:33)
    at /home/vsvydenko/.npm/_npx/292135/lib/node_modules/@eclipse-che/plugin-registry-generator/node_modules/simple-git/src/lib/runners/git-executor-chain.js:95:45
    at new Promise (<anonymous>)
    at GitExecutorChain.handleTaskData (/home/vsvydenko/.npm/_npx/292135/lib/node_modules/@eclipse-che/plugin-registry-generator/node_modules/simple-git/src/lib/runners/git-executor-chain.js:93:16)
    at GitExecutorChain.<anonymous> (/home/vsvydenko/.npm/_npx/292135/lib/node_modules/@eclipse-che/plugin-registry-generator/node_modules/simple-git/src/lib/runners/git-executor-chain.js:77:46)
    at Generator.next (<anonymous>)
    at fulfilled (/home/vsvydenko/.npm/_npx/292135/lib/node_modules/@eclipse-che/plugin-registry-generator/node_modules/simple-git/src/lib/runners/git-executor-chain.js:5:58)
Unable to start GitError: fatal: not a git repository (or any parent up to mount point /home)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

    at Object.action (/home/vsvydenko/.npm/_npx/292135/lib/node_modules/@eclipse-che/plugin-registry-generator/node_modules/simple-git/src/lib/plugins/error-detection.plugin.js:30:33)
    at PluginStore.exec (/home/vsvydenko/.npm/_npx/292135/lib/node_modules/@eclipse-che/plugin-registry-generator/node_modules/simple-git/src/lib/plugins/plugin-store.js:21:33)
    at /home/vsvydenko/.npm/_npx/292135/lib/node_modules/@eclipse-che/plugin-registry-generator/node_modules/simple-git/src/lib/runners/git-executor-chain.js:95:45
    at new Promise (<anonymous>)
    at GitExecutorChain.handleTaskData (/home/vsvydenko/.npm/_npx/292135/lib/node_modules/@eclipse-che/plugin-registry-generator/node_modules/simple-git/src/lib/runners/git-executor-chain.js:93:16)
    at GitExecutorChain.<anonymous> (/home/vsvydenko/.npm/_npx/292135/lib/node_modules/@eclipse-che/plugin-registry-generator/node_modules/simple-git/src/lib/runners/git-executor-chain.js:77:46)
    at Generator.next (<anonymous>)
    at fulfilled (/home/vsvydenko/.npm/_npx/292135/lib/node_modules/@eclipse-che/plugin-registry-generator/node_modules/simple-git/src/lib/runners/git-executor-chain.js:5:58) {
  task: {
    commands: [ 'rev-parse', '--show-toplevel' ],
    format: 'utf-8',
    parser: [Function: parser]
  }
}

Describe the solution you'd like

In case if parameter --skip-digest-generation was set as true we can skip code which requires simple-git library

@svor svor added kind/task Internal things, technical debt, and to-do tasks to be performed. team/plugins severity/P1 Has a major impact to usage or development of the system. area/plugins labels Jan 25, 2022
@svor svor self-assigned this Jan 25, 2022
@svor svor added this to the 7.43 milestone Jan 26, 2022
@svor svor closed this as completed Jan 26, 2022
@svor svor mentioned this issue Jan 27, 2022
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

1 participant