Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace conversion failed #21120

Closed
Tracked by #21103 ...
olexii4 opened this issue Feb 3, 2022 · 6 comments · Fixed by eclipse-che/che-dashboard#510
Closed
Tracked by #21103 ...

Workspace conversion failed #21120

olexii4 opened this issue Feb 3, 2022 · 6 comments · Fixed by eclipse-che/che-dashboard#510
Assignees
Labels
area/dashboard area/devfile-converter library used to convert v1 to v2 or v2 to v1 devfiles kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@olexii4
Copy link
Contributor

olexii4 commented Feb 3, 2022

Describe the bug

Workspace conversion failed if you try to convert workspaces that were created from these samples:

Che version

next (development version)

Steps to reproduce

  1. Deploy Eclipse-CHE with devWorkspace disabled.
  2. Open the 'Create Workspace' page.
  3. Create new workspaces from the samples: 'Rust', 'Apache Camel K', 'che4z'.
  4. Run
     chectl server:update --che-operator-cr-patch-yaml=...
    with a patch that enables devWorkspaces.
  5. Try to convert created workspaces.

Expected behavior

Workspaces should be successfully converted.

Runtime

minikube

Screenshots

apache-camel-k
2022-01-26__11_22_50

che4z
2022-01-26_11_30_04

rust
2022-01-26__11_33_54

Installation method

chectl/next

Environment

macOS

Eclipse Che Logs

No response

Additional context

No response

@olexii4 olexii4 added the kind/bug Outline of a bug - must adhere to the bug report template. label Feb 3, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 3, 2022
@ibuziuk ibuziuk added the severity/P1 Has a major impact to usage or development of the system. label Feb 3, 2022
@benoitf
Copy link
Contributor

benoitf commented Feb 3, 2022

I think you should provide .yaml/gist files of the devfiles in addition to the screenshot

@olexii4 olexii4 added area/dashboard and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Feb 4, 2022
@olexii4
Copy link
Contributor Author

olexii4 commented Feb 7, 2022

@benoitf I have added links to the issue description:

BTW: We have the same result with the 'Import from Git' widget.
2022-02-07_13_48_10

@ibuziuk
Copy link
Member

ibuziuk commented Apr 13, 2022

Also, have the covertion failure for cpp devfile

apiVersion: 1.0.0
metadata:
  name: cpp-test-convert
projects:
  - name: CPP
    source:
      location: 'https://codeready-codeready-workspaces-operator.apps.sandbox-m2.ll9k.p1.openshiftapps.com/devfile-registry/resources/cpp-CPP-master.zip'
      type: zip
components:
  - id: che-incubator/cpptools/latest
    preferences:
      clangd.path: /usr/bin/clangd
      cdt.clangd.binaries.enable: false
    type: chePlugin
    alias: cpp-plugin
  - mountSources: true
    memoryLimit: 512Mi
    type: dockerimage
    alias: cpp-dev
    image: 'registry.redhat.io/codeready-workspaces/stacks-cpp-rhel8@sha256:c2f38140f52112b2a7688c2a179afcaa930ad6216925eb322cfd9634a71cfc13'
  - id: eclipse-cdt/cdt-vscode/latest
    type: chePlugin
  - id: redhat/vscode-yaml/latest
    type: chePlugin
commands:
  - name: 1. Build current algorithm
    actions:
      - workdir: '${fileDirname}'
        type: exec
        command: 'rm -f "${fileDirname}"/bin.out && g++ -g "${file}" -o bin.out && echo "Build complete"'
        component: cpp-dev
  - name: 2. Run current algorithm
    actions:
      - workdir: '${fileDirname}'
        type: exec
        command: ./bin.out
        component: cpp-dev
  - name: Debug current algorithm
    actions:
      - referenceContent: |
          {
            "version": "0.2.0",
            "configurations": [
                {
                    "type": "gdb",
                    "name": "Debug current algorithm",
                    "request": "launch",
                    "program": "${fileDirname}/bin.out"
                }
            ]
          }
        type: vscode-launch

image

@benoitf
Copy link
Contributor

benoitf commented Apr 13, 2022

it's strange to have the failure for Cpp as the CPP tools plug-in is not there
https://eclipse-che.github.io/che-plugin-registry/main/v3/plugins/che-incubator/

it has been migrated to https://eclipse-che.github.io/che-plugin-registry/main/v3/plugins/eclipse-cdt/cdt-vscode/ almost a couple of years ago

@ibuziuk ibuziuk self-assigned this Apr 14, 2022
@ibuziuk
Copy link
Member

ibuziuk commented Apr 14, 2022

The rust convertion has been fixed. However there are still convertion issues for che4z / camel

Workspace conversion failed.
Failed to create a new workspace from the devfile, reason: Unable to resolve theia plugins: Not able to find any dev container component in DevWorkspace
Find manual instructions for converting devfile v1 to devfile v2 in the [documentation](https://devfile.io/docs/devfile/2.2.0/user-guide/migrating-to-devfile-v2/).

@benoitf wdyt maybe we can address it in the FAQ as part of the #21005 ?

e.g. how to add the dev container component to v1 devfile

@ibuziuk
Copy link
Member

ibuziuk commented Apr 20, 2022

Should be closed once eclipse-che/che-dashboard#510 backported to 7.46.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard area/devfile-converter library used to convert v1 to v2 or v2 to v1 devfiles kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants