Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OAuth flow and authenticate users against Git services at first workspace startup #21346

Closed
svor opened this issue Apr 25, 2022 · 2 comments
Closed

Use OAuth flow and authenticate users against Git services at first workspace startup #21346

svor opened this issue Apr 25, 2022 · 2 comments
Assignees
@benoitf
Labels
area/che-server area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Milestone
7.53

Comments

@svor
Copy link
Contributor

svor commented Apr 25, 2022 •
edited by l0rd
Loading

Is your task related to a problem? Please describe

At the moment when the administrator set up the GitHub, Gitlab or Bitbucket OAuth and the user has not logged in it yet, we ask to login only if the user starts a workspace of a private repository. As a result the secret is created automatically and Che has access to his Git account that makes much simpler to work with git project.

The idea of this task is to use OAuth flow to authenticate git user even if a workspace was started of a public repository.

Describe the solution you'd like

Prompt the user to do git authentication even if the repository is a public one

Release Notes Text

When starting a workspace for the first time users are prompted systematically to authenticate against the Git service provider if the OAuth flow has been enabled by the administrator. That allows to always inject personal tokens with git credentials in workspaces. That was done for private repositories only and it's now extended to any repository. The git services providers that are supported are GitHub SaaS, Gitlab on-prem and Bitbucket on-prem.
@svor svor added kind/task Internal things, technical debt, and to-do tasks to be performed. area/dashboard area/git labels Apr 25, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 25, 2022
@svor svor changed the title Use OAuth flow to authorize the user at the workspace startup Use OAuth flow to authorize the Git user at the workspace startup Apr 25, 2022
@svor svor mentioned this issue Apr 25, 2022
Closed
11 tasks
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. area/che-server and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Apr 25, 2022
@benoitf benoitf self-assigned this May 4, 2022
@benoitf benoitf mentioned this issue May 6, 2022
Merged
9 tasks
@benoitf
Copy link
Contributor

benoitf commented May 12, 2022

implemented by eclipse-che/che-server#301

@benoitf benoitf closed this as completed May 12, 2022
@l0rd l0rd changed the title Use OAuth flow to authorize the Git user at the workspace startup Always use OAuth flow to authenticate user against Git services (GitHub, Gitlab and Bitbucket) when a workspace starts May 12, 2022
@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels May 12, 2022
@l0rd l0rd changed the title Always use OAuth flow to authenticate user against Git services (GitHub, Gitlab and Bitbucket) when a workspace starts Use OAuth flow and authenticate users against Git services at first workspace startup May 12, 2022
@amisevsk amisevsk mentioned this issue May 31, 2022
Closed
@max-cx max-cx removed the status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording label Jan 12, 2023
@nickboldt nickboldt added this to the 7.53 milestone Jan 14, 2023
@devstudio-release
Copy link

sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-3848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoitf benoitf

Labels
area/che-server area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.53
Development

No branches or pull requests
7 participants
@nickboldt @benoitf @l0rd @svor @devstudio-release @che-bot @max-cx