Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Che-Code automatic rebase against upstream VS Code is failed #21439

Closed
Tracked by #21395
azatsarynnyy opened this issue Jun 3, 2022 · 4 comments · Fixed by che-incubator/che-code#53
Closed
Tracked by #21395

Che-Code automatic rebase against upstream VS Code is failed #21439

azatsarynnyy opened this issue Jun 3, 2022 · 4 comments · Fixed by che-incubator/che-code#53
Assignees
@azatsarynnyy
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone
7.49

Comments

@azatsarynnyy
Copy link
Member

Is your task related to a problem? Please describe

The GitHub Workflow for Che-Code automatic rebase against upstream VS Code is failed since May 30:
https://github.com/che-incubator/che-code/actions/workflows/rebase-insiders.yml

Describe the solution you'd like

It requires some manual steps. Most likely, updating the NodeJS version is required.

#11 0.477 *** Please use node.js versions >=16.14.x and <17.

Describe alternatives you've considered

No response

Additional context

No response
@azatsarynnyy azatsarynnyy added kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current severity/P1 Has a major impact to usage or development of the system. team/editors area/editor/vscode Issues related to the Code OSS editor of Che labels Jun 3, 2022
@azatsarynnyy azatsarynnyy added this to the 7.49 milestone Jun 3, 2022
@azatsarynnyy azatsarynnyy self-assigned this Jun 3, 2022
@azatsarynnyy azatsarynnyy mentioned this issue Jun 3, 2022
Closed
49 tasks
@azatsarynnyy azatsarynnyy changed the title Che-Code automatic rebase against upstream VS Code requires manual steps Che-Code automatic rebase against upstream VS Code is failed Jun 3, 2022
@azatsarynnyy
Copy link
Member Author

We use Node.js v16.13.1 for Che-Code build.
https://github.com/che-incubator/che-code/blob/6380441447624460b01b4552864ff96a240e9c19/build/dockerfiles/linux-libc.Dockerfile#L10

> docker run -it registry.access.redhat.com/ubi8/nodejs-16:1-18 node --version
v16.13.1

But, VS Code requires Node.js >=16.14.x and <17. See microsoft/vscode@2bc5dda

@azatsarynnyy azatsarynnyy mentioned this issue Jun 3, 2022
Merged
@azatsarynnyy
Copy link
Member Author 

> docker run -it registry.access.redhat.com/ubi8/nodejs-16:1-37.1652296488 node --version
v16.14.0

I'm checking it in che-incubator/che-code#53

@azatsarynnyy
Copy link
Member Author

checking the rebase job https://github.com/che-incubator/che-code/actions/runs/2435238503

@azatsarynnyy azatsarynnyy reopened this Jun 3, 2022
@azatsarynnyy
Copy link
Member Author

The automatic rebase is restored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azatsarynnyy azatsarynnyy

Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Milestone
7.49
1 participant
@azatsarynnyy