-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PowerShell VS Code extension failed to start #21626
Comments
Previously, I assumed that our machine-exec implementation of the terminal prevented the PowerShell extension from working correctly. But the assumption was not confirmed. Moreover, I prepared the Che-Code build without a machine-exec terminal for testing and the described problem is not reproduced in both cases: with and w/o the machine-exec.
First thing I noticed, the extension is not hanging at startup anymore. I tried cc @l0rd |
I just realized I was using the wrong extension 🤦♂️ |
It turned out that providing a custom editor through the
|
The result of testing without the machine-exec ⬇️ After installing the PowerShell extension
|
The result of testing with the machine-exec ⬇️ After installing the PowerShell extension
Also, the notifications: |
Actually, my previous assumption is confirmed 🙂 To fix all these problems, we can disable the machine-exec support until we decide if we really needed it, or until we rework it and make sure our implementation works well with the existing terminal-related functionality in VS Code. Disabling the machine-exec support means:
Also, disabling the machine-exec support should fix the problems with running non-che tasks (like So, I think it would be better if we disable the machine-exec support (as it's currently implemented) to get the VS Code features to work correctly. And, probably, return back to that topic later taking into account all these problems we've discovered. |
+1 to drop the machine-exec support. I expect that then we can also re-enable shell integration. But being able to open a terminal on a non-editor container and supporting Devfile commands as VS Code tasks are 2 features that we cannot drop. If possible I would like to make the drop of machine-exec step by step: 1) drop machine-exec support for the default terminal (but still use machine exec for non-editor containers and for tasks) 2) support devfile commands as tasks without using machine-exec (but still use machine exec for non-editor containers) 3) support terminal on non-editor containers without machine-exec. |
We should also verify what was mentioned by @ibuziuk: user kubeconfig should continue to be automatically injected when starting a workspace from the dashboard. |
And thanks @azatsarynnyy, great investigation. |
The work on the new terminal extension is tracked in the issue #21673 |
@azatsarynnyy can we close this? Asking to decide if we can include it in the 7.55 release notes |
All the PowerShell extension-related issues, I've detected, are fixed by:
Now, we can close this issue. |
Is your task related to a problem? Please describe
PowerShell VS Code extension failed to start in Che-Code.
Describe the solution you'd like
Need to investigate why the extension waits for the session file continuously.
Describe alternatives you've considered
No response
Additional context
The text was updated successfully, but these errors were encountered: