Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default VSX registry should be openvsx.org #21637

Closed
Tracked by #21615
l0rd opened this issue Aug 16, 2022 · 2 comments
Closed
Tracked by #21615

The default VSX registry should be openvsx.org #21637

l0rd opened this issue Aug 16, 2022 · 2 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Aug 16, 2022

Is your enhancement related to a problem? Please describe

We are about to embed an OpenVSX registry in Che plugin registry but that hasn't be tested thoroughly yet and we still want to use openvsx.org as the default registry to retrieve VS Code extensions.

Describe the solution you'd like

When installing Che (via OLM or yaml manifests), the default CheCluster should have pluginRegistry.openVSXURL set to https://openvsx.org.

When updating Che v7.51 or earlier, if pluginRegistry.openVSXURL is NOT set then we should set it to https://openvsx.org.

When updating Che v7.52 or later, if pluginRegistry.openVSXURL is NOT set then we should not modify it.

Additional context

We introduced the pluginRegistry.openVSXURL with this PR but that field is empty by default (meaning that the embedded registry will be used).

OpenVSX is greedy in terms of memory requirements.

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Aug 16, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 16, 2022
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. area/plugin-registry area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. area/plugin-registry labels Aug 16, 2022
@tolusha tolusha closed this as completed Aug 17, 2022
@tolusha tolusha modified the milestones: 7.52, 7.53 Aug 17, 2022
@tolusha tolusha mentioned this issue Aug 17, 2022
67 tasks
@svor
Copy link
Contributor

svor commented Aug 26, 2022

When updating Che v7.52 or later, if pluginRegistry.openVSXURL is NOT set then we should not modify it.

@l0rd @tolusha it means that updated Che v7.53 will have empty value of openVSXURL and will use the embedded registry. It changes the previous state that was in v7.52 were we use online registry.

maybe we should:
When updating Che v7.52 or earlier, if pluginRegistry.openVSXURL is NOT set then we should set it to https://openvsx.org/.
When update Che v7.53 or later, if pluginRegistry.openVSXURL is NOT set then we should not modify it.

@l0rd
Copy link
Contributor Author

l0rd commented Sep 1, 2022

@svor I think you are right: in v7.52 and earlier version pluginRegistry.openVSXURL is empty by default (but openvsx.org is supposed to be used). It's only from v7.53 that pluginRegistry.openVSXURL is set by default to https://openvsx.org. My bad, I got confused with the release numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants