Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Existing workspaces can not be started on the dogfooding instance: DevWorkspace storage-type attribute cannot be changed once the workspace has been created. #21707

Closed
ibuziuk opened this issue Sep 16, 2022 · 5 comments
Closed

Existing workspaces can not be started on the dogfooding instance: DevWorkspace storage-type attribute cannot be changed once the workspace has been created. #21707

ibuziuk opened this issue Sep 16, 2022 · 5 comments
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Sep 16, 2022 •
edited
Loading

Is your task related to a problem? Please describe

After adding storage type-related attributes - eclipse-che/che-dashboard#625
existing workspaces can not be started: Failed to start the workspace empty-2dm4, reason: Failed to update workspace 'empty-2dm4'. Unable to patch devworkspace: admission webhook "mutate.devworkspace-controller.svc" denied the request: DevWorkspace storage-type attribute cannot be changed once the workspace has been created.

image

Describe the solution you'd like

Workspace should be started correctly

Describe alternatives you've considered

potentially, we should drop the webhook at all, and allow swithing the storage type, but warn the admin somehow that it could lead to the data loss

Additional context

No response
@ibuziuk ibuziuk added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Sep 16, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 16, 2022
@ibuziuk ibuziuk added engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. labels Sep 16, 2022
@ibuziuk ibuziuk changed the title Existing workspaces can not be started on the dogffoding instance: DevWorkspace storage-type attribute cannot be changed once the workspace has been created. Existing workspaces can not be started on the dogfooding instance: DevWorkspace storage-type attribute cannot be changed once the workspace has been created. Sep 16, 2022
This was referenced Sep 16, 2022
Merged
Closed
@ibuziuk
Copy link
Member Author

ibuziuk commented Sep 16, 2022 •
edited
Loading

PR has been sent - devfile/devworkspace-operator#927
however, we should consider potentially removing the storage webhook entirely

@ibuziuk
Copy link
Member Author

ibuziuk commented Sep 16, 2022

@olexii4 one other potential problem that we should avoid is patching DW during startup. I thought that this should have been fixed by eclipse-che/che-dashboard#626
but please do check that we add storage attributes before (not during startup)

@amisevsk
Copy link
Contributor

This is still not resolved due to #21714. I've opened DWO PR devfile/devworkspace-operator#932 to workaround the issue for now.

@amisevsk amisevsk mentioned this issue Sep 19, 2022
Merged
3 tasks
@dkwon17 dkwon17 removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 20, 2022
@l0rd
Copy link
Contributor

l0rd commented Sep 21, 2022

@amisevsk @AObuchow can you please confirm if this issue has been addressed and we can move forward with the release of 7.54.0

@amisevsk
Copy link
Contributor

This issue is resolved in DWO next in devfile/devworkspace-operator#932 and DWO v0.16.0 in devfile/devworkspace-operator#933. However, it will be present if DWO v0.15.x and earlier is used, as the webhook is present in those releases.

The proper fix for this issue would be resolving #21714 in order to not update the storage type for existing workspaces. The workaround we have implemented is to just remove a previously-included webhook that blocks changing the storage type for DevWorkspaces.

I'll close this issue since it's no longer present, and further progress can be tracked in #21714.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@l0rd @ibuziuk @amisevsk @che-bot @dkwon17