Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using deprecated KeyboardEvent.keyIdentifier #2209

Closed
azatsarynnyy opened this issue Aug 25, 2016 · 0 comments
Closed

Avoid using deprecated KeyboardEvent.keyIdentifier #2209

azatsarynnyy opened this issue Aug 25, 2016 · 0 comments
Assignees
@azatsarynnyy
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Milestone
5.0.0-M1

Comments

@azatsarynnyy
Copy link
Member

Chrome of the latest stable version (52) shows the warning:

'KeyboardEvent.keyIdentifier' is deprecated and will be removed in M53, around September 2016. See https://www.chromestatus.com/features/5316065118650368 for more details.

Brief search shows that our Tree component uses that keyIdentifier property.
So need to avoid using keyIdentifier property in order to avoid possible problems in Chrome 53.
@azatsarynnyy azatsarynnyy added kind/enhancement A feature request - must adhere to the feature request template. sprint/next team/ide labels Aug 25, 2016
@vparfonov vparfonov added sprint/current status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. and removed sprint/next labels Sep 2, 2016
@azatsarynnyy azatsarynnyy added this to the 4.8.0 milestone Sep 2, 2016
@azatsarynnyy azatsarynnyy self-assigned this Sep 2, 2016
@azatsarynnyy azatsarynnyy added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Sep 2, 2016
@bmicklea bmicklea mentioned this issue Sep 6, 2016
Closed
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azatsarynnyy azatsarynnyy

Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
5.0.0-M1
Development

No branches or pull requests
2 participants
@azatsarynnyy @vparfonov