Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CSV and CRD references to now-obsolete postgres variables #22214

Closed
nickboldt opened this issue May 16, 2023 · 1 comment
Closed

Remove CSV and CRD references to now-obsolete postgres variables #22214

nickboldt opened this issue May 16, 2023 · 1 comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed.
Milestone
7.68

Comments

@nickboldt
Copy link
Contributor

nickboldt commented May 16, 2023 •
edited
Loading

Is your task related to a problem? Please describe

There are still many references to postgres in the CSV and CRD; as postgres is no longer used, these should be removed.

./bundle/next/eclipse-che/manifests/che-operator.clusterserviceversion.yaml 
./bundle/next/eclipse-che/manifests/org.eclipse.che_checlusters.yaml 
./bundle/stable/eclipse-che/manifests/che-operator.clusterserviceversion.yaml 
./bundle/stable/eclipse-che/manifests/org.eclipse.che_checlusters.yaml ./config/crd/bases/org.eclipse.che_checlusters.yaml 
./config/manifests/bases/che-operator.clusterserviceversion.yaml 
./deploy/deployment/kubernetes/combined.yaml ./deploy/deployment/kubernetes/objects/checlusters.org.eclipse.che.CustomResourceDefinition.yaml 
./deploy/deployment/openshift/combined.yaml 
./deploy/deployment/openshift/objects/checlusters.org.eclipse.che.CustomResourceDefinition.yaml 
./helmcharts/next/crds/checlusters.org.eclipse.che.CustomResourceDefinition.yaml 
./helmcharts/stable/crds/checlusters.org.eclipse.che.CustomResourceDefinition.yaml

Describe the solution you'd like

Remove mention of postgres since it's no longer included as of 7.62.

Describe alternatives you've considered

No response

Additional context

Continues from #21374 and https://issues.redhat.com/browse/CRW-4105
@nickboldt nickboldt added the kind/task Internal things, technical debt, and to-do tasks to be performed. label May 16, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label May 16, 2023
@dkwon17 dkwon17 removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label May 16, 2023
@tolusha tolusha added the area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator label May 22, 2023
@tolusha
Copy link
Contributor

tolusha commented May 22, 2023

It is safe enough to remove those 2 fields from the CheCluster spec:

@tolusha tolusha mentioned this issue May 22, 2023
Merged
10 tasks
@tolusha tolusha added this to the 7.68 milestone May 24, 2023
@tolusha tolusha closed this as completed May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.68
Development

No branches or pull requests
4 participants
@nickboldt @tolusha @che-bot @dkwon17