Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a User, I want to be warned that creating a workspace from unknown source could be dangerous #23018

Closed
ibuziuk opened this issue Jun 26, 2024 · 2 comments · Fixed by eclipse-che/che-dashboard#1152
Closed

As a User, I want to be warned that creating a workspace from unknown source could be dangerous #23018

ibuziuk opened this issue Jun 26, 2024 · 2 comments · Fixed by eclipse-che/che-dashboard#1152
Assignees
@akurinnoy
Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Jun 26, 2024

Is your enhancement related to a problem? Please describe

As a User, I want to be warned that creating a workspace from an unknown source could be dangerous

Describe the solution you'd like

It is recommended not to create workspaces automatically, but first to show a user a warning message that describes the possible dangers of creating workspaces from unknown or untrusted repositories.
Potentially, add functionality to allowlist the list of repo that the administrator has to approve first.

Describe alternatives you've considered

No response

Additional context

Example of a similar functionality in Code OSS
Screenshot 2024-06-26 at 13 58 13
@ibuziuk ibuziuk added the kind/enhancement A feature request - must adhere to the feature request template. label Jun 26, 2024
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jun 26, 2024
@ibuziuk ibuziuk added the severity/P1 Has a major impact to usage or development of the system. label Jun 26, 2024
@ibuziuk ibuziuk moved this to 📅 Planned in Eclipse Che Team A Backlog Jun 26, 2024
@ibuziuk ibuziuk added area/dashboard severity/P1 Has a major impact to usage or development of the system. and removed severity/P1 Has a major impact to usage or development of the system. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jun 26, 2024
@olexii4 olexii4 assigned akurinnoy and unassigned olexii4 Jul 2, 2024
@ibuziuk ibuziuk moved this from 📅 Planned to 🚧 In Progress in Eclipse Che Team A Backlog Jul 17, 2024
@akurinnoy
Copy link
Contributor

Hi @ibuziuk, I prepared some figma prototypes of what this warning might look like on the Getting Started and Workspace startup pages.

Getting Started
https://www.figma.com/proto/YcjE2a2NVzBsd8tMKZhzvH/Untrusted-main?page-id=0%3A1&node-id=10-27&viewport=294%2C512%2C0.08&t=4zIUgTuU2mkc2nkJ-1&scaling=contain&content-scaling=fixed&starting-point-node-id=10%3A27

Workspace startup (with a modal warning)
https://www.figma.com/proto/wlg9f5ic7IiZhaHqRwAY1M/Untrusted-startup-1?page-id=0%3A1&node-id=1-7&viewport=561%2C175%2C0.07&t=HKMPA6cbEzcOMEsa-1&scaling=contain&content-scaling=fixed&starting-point-node-id=1%3A7

Workspace startup (with inline warning)
https://www.figma.com/proto/65O4RMIqtu4MEtXiR4cgOl/Untrusted-startup-2?page-id=0%3A1&node-id=1-2&viewport=1023%2C911%2C0.25&t=BcHADMo1ne9Om9ea-1&scaling=min-zoom&content-scaling=fixed&starting-point-node-id=1%3A2

@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 17, 2024

@akurinnoy great mockups. I personally like Getting Started + Workspace startup (with a modal warning) combo

@akurinnoy akurinnoy mentioned this issue Jul 26, 2024
Merged
@akurinnoy akurinnoy moved this from 🚧 In Progress to Ready for Review in Eclipse Che Team A Backlog Jul 30, 2024
@ibuziuk ibuziuk moved this from Ready for Review to 🚧 In Progress in Eclipse Che Team A Backlog Aug 7, 2024
@dmytro-ndp dmytro-ndp mentioned this issue Aug 15, 2024
Open
@akurinnoy akurinnoy moved this from 🚧 In Progress to ✅ Done in Eclipse Che Team A Backlog Aug 15, 2024
@ibuziuk ibuziuk mentioned this issue Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akurinnoy akurinnoy

Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
Eclipse Che Team A Backlog
Status: ✅ Done
Red Hat OpenShift Dev Spaces and Web Terminal Priorities
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Untrusted source warning eclipse-che/che-dashboard
4 participants
@ibuziuk @olexii4 @akurinnoy @che-bot