Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an admin, I would like to specify the allowList of the URLs based on which workspaces / CDEs can be started #23030

Closed
ibuziuk opened this issue Jul 8, 2024 · 10 comments
Assignees
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Jul 8, 2024

Is your task related to a problem? Please describe

As an admin, I would like to specify the allowList of the URLs based on which workspaces / CDEs can be started e.g.

  • only from private GitHub, BitBucket, Azure, Gitlab
  • only from particular org
  • only from ssh of particular repo etc

Describe the solution you'd like

potential СR semantics

  devEnvironments:
      allowList / allowURLs / ? :
         - https://github.com # allow from github
         - git@github.com # allow from github over ssh
         - https://github.com/eclipse-che # allow particular group
         - https://github.com/eclipse-che/che # allow particular repo from github
         - etc.. # similar for other providers

Describe alternatives you've considered

N/A

Additional context

allowList is empty by default - all repos should be allowes

@ibuziuk ibuziuk added status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach kind/task Internal things, technical debt, and to-do tasks to be performed. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/dashboard area/che-server labels Jul 8, 2024
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 8, 2024
@ibuziuk ibuziuk changed the title As an admin, I would like to specify the allowList of the URLs based on which workspaces / CDEs can be started As an admin, I would like to specify the allowList of the URLs based on which workspaces / CDEs can be started Jul 8, 2024
@ibuziuk ibuziuk added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 8, 2024
@ibuziuk ibuziuk moved this to 📅 Planned in Eclipse Che Team A Backlog Jul 17, 2024
@tolusha
Copy link
Contributor

tolusha commented Aug 12, 2024

devEnvironments:
  allowedWorkspaceStartUrls:
    - "https://github.com"
    - "https://gitlab.com/your-group"
 

@ibuziuk
Copy link
Member Author

ibuziuk commented Aug 14, 2024

@tolusha I believe we need smth. better

@ibuziuk
Copy link
Member Author

ibuziuk commented Aug 14, 2024

@tolusha allowedGitUrls / allowedGitURLs ?

@tolusha
Copy link
Contributor

tolusha commented Aug 14, 2024

It might be any urls, not just git ones

@tolusha
Copy link
Contributor

tolusha commented Aug 14, 2024

allowedWorkspaceSourceUrls

@ibuziuk
Copy link
Member Author

ibuziuk commented Aug 14, 2024

we should not use Workspace wording IMO.

It might be any urls, not just git ones

How come? we support only git no? no matter if it is self-hosted / ssh / provider etc.

@tolusha
Copy link
Contributor

tolusha commented Aug 14, 2024

I mean it can be a raw devfile url.
Which basically can be anything.

@ibuziuk
Copy link
Member Author

ibuziuk commented Aug 14, 2024

devEnvironments:
  allowedUrls | allowedSourceUrls 

?

@ibuziuk
Copy link
Member Author

ibuziuk commented Sep 18, 2024

@tolusha all PRs seems to be merged. Can we close?

@tolusha
Copy link
Contributor

tolusha commented Sep 18, 2024

I am writing the documentation..

@tolusha tolusha removed status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach area/che-server labels Sep 19, 2024
@tolusha tolusha closed this as completed Sep 20, 2024
@tolusha tolusha moved this from 🚧 In Progress to ✅ Done in Eclipse Che Team A Backlog Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Development

No branches or pull requests

3 participants