Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is there connections between port 4411 and the host where the web browser is opened? #3211

Closed
agnesagnes opened this issue Nov 30, 2016 · 3 comments
Labels
kind/question Questions that haven't been identified as being feature requests or bugs.

Comments

@agnesagnes
Copy link

agnesagnes commented Nov 30, 2016

I'm currently trying to understand how the che-websocket-terminal works. And, to first understand the communications done, I wrote lsof -i:4411.
I would like to know why you need to open ports on the host where the web page is opened? (By the way I'm using Eclipse Che 4.7.0 but I see the che-websocket-terminal project didn't change since).

Result of lsof -i:4411:

COMMAND ...   NAME 
che-webso   .... xxxx:4411->ip.of.first.computer:57280 (ESTABLISHED)
che-webso   .... xxxx:4411->ip.of.first.computer:57288 (ESTABLISHED)
che-webso   .... xxxx:4411->ip.of.second.computer:59689 (ESTABLISHED)
che-webso   .... xxxx:4411->ip.of.second.computer:59691 (ESTABLISHED)
che-webso   .... xxxx:4411->ip.of.second.computer:57280 (ESTABLISHED)

ip.of.first.computer/ip.of.second.computer is the ip of the first/second host where I opened an Eclipse Che workspace in a web browser.
Each time I click on "New terminal" that inputs a new terminal, a new connection is established. (by the way, when I close the terminal, the connection is still there).

@TylerJewell TylerJewell added the kind/question Questions that haven't been identified as being feature requests or bugs. label Nov 30, 2016
@TylerJewell
Copy link

@vkuznyetsov - can you please ask someone about the details of this?

@AndrienkoAleksandr
Copy link
Contributor

Hi @agnesagnes . For now we didn't implement yet restore terminal, so we create separated terminal process for every new one websocket connection. We can kill terminal process and it's child processes on closing websocket connection, but it has bad side effect: if user started some long time background process (for example started tomcat server with some application) after refreshing browser page, user will see that his process was killed. We can detaches child processes and kill terminal process, but it worse and it is not safe operation, some child processes can not be detached at all, some of them become unstable state (and user won't be know what happen) and detaching process operation is OS dependent. I think good desing it will be implement terminal restore. And about "connection is still" alive. I think it should be fixed by eclipse-che/che-lib#11. Can you get me more detail about this? And about open port, we have authentification on the Codenvy terminal, but for CHE terminal it is not implemented.

@AndrienkoAleksandr
Copy link
Contributor

#3216 maybe it's related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Questions that haven't been identified as being feature requests or bugs.
Projects
None yet
Development

No branches or pull requests

3 participants