Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Factory] Remove {username} from named URL factories #4500

Closed
slemeur opened this issue Mar 21, 2017 · 2 comments
Closed

[Factory] Remove {username} from named URL factories #4500

slemeur opened this issue Mar 21, 2017 · 2 comments
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@slemeur
Copy link
Contributor

slemeur commented Mar 21, 2017

A named factory on Codenvy is attached to a username. We support the various format:

  • /f?user={username}&name={factoryname}
  • /factory?user={username}&name={factoryname}
    We need to remove the {username} for Che as it will be always {che}.

We can keep the /f?user=che&name={factoryname} but we need to handle that kind of url:

  • /f?name={factoryname}
  • /factory?name={factoryname}
@slemeur slemeur added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Mar 21, 2017
@skabashnyuk
Copy link
Contributor

Removed /factory/username/factoryname and /factory/factoryname since they wasn't implemented

@skabashnyuk
Copy link
Contributor

Decided to abandon this issue. Since we may be will need user name. We will left fake user "che".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

2 participants