Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes terminal scrollport adds one exceed line than terminal need #5084

Closed
AndrienkoAleksandr opened this issue May 16, 2017 · 3 comments
Closed

Sometimes terminal scrollport adds one exceed line than terminal need #5084

AndrienkoAleksandr opened this issue May 16, 2017 · 3 comments
Assignees
@AndrienkoAleksandr
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage.

Comments

@AndrienkoAleksandr
Copy link
Contributor

Reproduction Steps:

  1. Open terminal.
  2. Open Midnight Commander by typing "mc"
  3. Resize terminal few times and click to the item "Help". If all Ok, try few times.

Actual result: terminal scrollport adds one exceed line and terminal input becomes broken.
Expected result: amount terminal lines in the scrollport should be the same like in the terminal widget.

terminal_exceed_line

OS and version:
os version: Fedora 25.
CHE version: 5.10.0-SNAPSHOT
@AndrienkoAleksandr AndrienkoAleksandr added kind/bug Outline of a bug - must adhere to the bug report template. team/enterprise labels May 16, 2017
@AndrienkoAleksandr AndrienkoAleksandr self-assigned this May 16, 2017
@vkuznyetsov vkuznyetsov added sprint/next status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels May 16, 2017
@AndrienkoAleksandr AndrienkoAleksandr added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels May 16, 2017
@AndrienkoAleksandr AndrienkoAleksandr mentioned this issue May 24, 2017
Closed
@AndrienkoAleksandr AndrienkoAleksandr added status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Jun 13, 2017
@AndrienkoAleksandr
Copy link
Contributor Author

I have a branch where is I'm working on fix for this issue: https://github.com/AndrienkoAleksandr/xterm.js/tree/CHE-5084 . But while I was working on this issue I saw that I need normal buffers to store info about current active terminal screen. And I saw such mechanism in the branch https://github.com/sourcelair/xterm.js/tree/buffer-set . So I will merge my changes with this branch.
I created few pull requests for stabilization branch "buffer-set", because it still in progress:
xtermjs/xterm.js#728
xtermjs/xterm.js#740
xtermjs/xterm.js#739
So this issue depends on "buffer-set" and I'm awaiting on merge my pull requests.

@vkuznyetsov vkuznyetsov added status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. and removed status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach labels Jun 30, 2017
@AndrienkoAleksandr AndrienkoAleksandr added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. labels Jul 12, 2017
@AndrienkoAleksandr
Copy link
Contributor Author

Buffer-Set branch merged. Guys from xterm.js created pull request https://github.com/sourcelair/xterm.js/pull/855/files to fix current issue, but into branch xterm.js 3.0. So we need create cq and update xterm.js to the version 3.0 when it will be released.

@AndrienkoAleksandr AndrienkoAleksandr removed the status/in-progress This issue has been taken by an engineer and is under active development. label Aug 15, 2017
@vkuznyetsov vkuznyetsov added status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. and removed sprint/current labels Aug 15, 2017
@tolusha tolusha added status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. and removed status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. labels Sep 14, 2017
@AndrienkoAleksandr AndrienkoAleksandr mentioned this issue Nov 14, 2017
Closed
@vkuznyetsov vkuznyetsov added the severity/P2 Has a minor but important impact to the usage or development of the system. label Jul 25, 2018
@SkorikSergey
Copy link
Contributor

Cannot reproduce in CHE 6.12.0-SNAPSHOT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrienkoAleksandr AndrienkoAleksandr

Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tolusha @vkuznyetsov @AndrienkoAleksandr @SkorikSergey