Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove core/process -> core/rpc dependency #5149

Closed
voievodin opened this issue May 22, 2017 · 0 comments · Fixed by #5225
Closed

Remove core/process -> core/rpc dependency #5149

voievodin opened this issue May 22, 2017 · 0 comments · Fixed by #5225
Assignees
@voievodin
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.

Comments

@voievodin
Copy link
Contributor

exec-agent/process package becomes core/process which allows to reuse it by different components. core/process package should not use a certain type of transport to bring its events to its clients, BUT it uses jsonrpc events right now as exec-agent didn't need anything else.

Agent installer needs core/process functionality to execute agent installation scripts and stream its own events to the client, in this case core/process lib will do unnecessary work by wrapping process entities with jsonrpc models and agent installer will unwrap them back.

The goal of the issue is to decouple core/process and core/rpc.

Depends on #5131
@voievodin voievodin added the kind/task Internal things, technical debt, and to-do tasks to be performed. label May 22, 2017
@voievodin voievodin self-assigned this May 22, 2017
@gazarenkov gazarenkov mentioned this issue May 22, 2017
Closed
12 tasks
@voievodin voievodin added the status/in-progress This issue has been taken by an engineer and is under active development. label May 26, 2017
@voievodin voievodin mentioned this issue May 29, 2017
Merged
@skabashnyuk skabashnyuk added sprint/current status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/platform and removed status/in-progress This issue has been taken by an engineer and is under active development. labels May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@voievodin voievodin

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[go-agents] Ged rid of core/process -> core/rpc dependency eclipse-che/che
2 participants
@skabashnyuk @voievodin