Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework server pinging to make it more interactive and fast #5420

Closed
garagatyi opened this issue Jun 21, 2017 · 5 comments
Closed

Rework server pinging to make it more interactive and fast #5420

garagatyi opened this issue Jun 21, 2017 · 5 comments
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@garagatyi
Copy link

Now pinging of the servers is sequential and slow. We should rework it to allow a really interactive load of Workspace and speed up the whole process.

@garagatyi garagatyi added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jun 21, 2017
@gazarenkov
Copy link
Contributor

Could you please be more precise, what exactly should be reworked?

@garagatyi
Copy link
Author

Right now we ping server by server. So while we are pinging the first one others might have already been available, but we will wait until the check of the first one succeeded. So it is not really interactive from client POV.
So we want to rework this component in such a way that if a server is already available then we send an event to the client about that even if this is the last server from our list.

@gazarenkov
Copy link
Contributor

I guess you are talking about some technical debt in the Docker impl, right?
I would suggest to be more precise, if you just point out the class you see the problem in, it would worth many words :)

@garagatyi
Copy link
Author

yes, it is all about technical debt in Docker infra impl.
Here is the code I'm talking about.

@gazarenkov
Copy link
Contributor

I see, thanks

@akorneta akorneta self-assigned this Jul 4, 2017
@akorneta akorneta added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Jul 4, 2017
@akorneta akorneta removed their assignment Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

3 participants