Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover servers logs streaming #5675

Closed
voievodin opened this issue Jul 17, 2017 · 1 comment
Closed

Recover servers logs streaming #5675

voievodin opened this issue Jul 17, 2017 · 1 comment
Assignees
Labels
target/branch Indicates that a PR will be merged into a branch other than master.

Comments

@voievodin
Copy link
Contributor

voievodin commented Jul 17, 2017

Bootstrapper continues streaming logs after workspace is started and there is at least one server.
But right now there is no way to reconnect to the logs stream after master is restarted.
I see several ways to solve this issue:

  1. Bootstrapper attempts to reconnect to master once disconnected.
  2. Master asks bootstrapper to continue logs streaming sending push-logs-endpoint to it.
  3. Master connects to bootstrapper and asks to stream logs using established connection.

I would start from the option 1, as it is the simplest way to achieve recovery.

The logs format is defined in the bootstrapper spec.

Needed for #5097
Needs #5814

@voievodin voievodin added the target/branch Indicates that a PR will be merged into a branch other than master. label Jul 17, 2017
@voievodin voievodin self-assigned this Jul 21, 2017
@voievodin voievodin added the status/in-progress This issue has been taken by an engineer and is under active development. label Jul 21, 2017
@voievodin voievodin removed the status/in-progress This issue has been taken by an engineer and is under active development. label Jul 27, 2017
@garagatyi
Copy link

I believe that this issue is fixed by @evoevodin but doesn't work because of behavior described in #5814. Closing the issue, feel free to reopen if this feature won't work after the closure of the mentioned issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

No branches or pull requests

2 participants