Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add using of persistent volumes for storing sources of projects #5691

Closed
sleshchenko opened this issue Jul 17, 2017 · 10 comments
Closed

Add using of persistent volumes for storing sources of projects #5691

sleshchenko opened this issue Jul 17, 2017 · 10 comments
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@sleshchenko
Copy link
Member

Not to lose local changes in sources of projects after workspace restarting we should use persistent volumes for storing sources of projects.

@bmicklea
Copy link

Please add correct labels.

@sleshchenko sleshchenko added the kind/enhancement A feature request - must adhere to the feature request template. label Jul 20, 2017
@gazarenkov gazarenkov added kind/task Internal things, technical debt, and to-do tasks to be performed. and removed kind/enhancement A feature request - must adhere to the feature request template. labels Jul 25, 2017
@akorneta akorneta self-assigned this Aug 8, 2017
@akorneta akorneta added the status/in-progress This issue has been taken by an engineer and is under active development. label Aug 8, 2017
@gorkem
Copy link
Contributor

gorkem commented Aug 10, 2017

Every PV has different characteristic depending on the backend performance may be different? Is this going to be configurable?

@akorneta
Copy link
Contributor

@gorkem I'm not sure that I fully understand question, could you please clarify what exactly should be configurable?

@benoitf
Copy link
Contributor

benoitf commented Aug 10, 2017

there are several implementations of PV : https://docs.openshift.com/enterprise/3.1/install_config/persistent_storage/index.html

@akorneta
Copy link
Contributor

akorneta commented Aug 10, 2017

@benoitf So we do not manage PVs in che at all. The current issue is about adding PVCs for storing workspace projects. As far as I understand PVC doesn't provide an ability to choose which back end should be used. It is a part of OpenShift instance configuration managed by admins or I missed something?

@benoitf
Copy link
Contributor

benoitf commented Aug 10, 2017

@akorneta when you claim a persistent volume, you ask for characteristics

https://docs.openshift.com/enterprise/3.0/architecture/additional_concepts/storage.html#persistent-volume-claims
like the access mode, etc.

so maybe you want to be able to choose options of the PV claim.

@gorkem
Copy link
Contributor

gorkem commented Aug 10, 2017

It is not even that advanced. Some PVCs are slow for small writes but optimized for larger writes. I think we should have the option disable persistent volume storing in case we see that it affects the performance of the IDE.

@akorneta
Copy link
Contributor

akorneta commented Aug 10, 2017

Current implementation of OpenShiftConnector has hard coded access mode to ReadWriteOne and has configurable quantity. I'm going to make configuration property for quantity.
@benoitf Do you think that it makes sense to make access mode configurable?

disable persistent volume

@gorkem But then we may lose changes of projects sources after workspace restart or crash. I think it is not good UX. Do you think it is acceptable?

@gorkem
Copy link
Contributor

gorkem commented Aug 10, 2017

It is not good UX but I was thinking of it as a fallback if PV starts to render IDE unusable.

@akorneta
Copy link
Contributor

@gorkem ok it makes sense I'll add appropriate config property

@akorneta akorneta removed the status/in-progress This issue has been taken by an engineer and is under active development. label Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

6 participants