-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add using of persistent volumes for storing sources of projects #5691
Comments
Please add correct labels. |
Every PV has different characteristic depending on the backend performance may be different? Is this going to be configurable? |
@gorkem I'm not sure that I fully understand question, could you please clarify what exactly should be configurable? |
there are several implementations of PV : https://docs.openshift.com/enterprise/3.1/install_config/persistent_storage/index.html |
@benoitf So we do not manage PVs in che at all. The current issue is about adding PVCs for storing workspace projects. As far as I understand PVC doesn't provide an ability to choose which back end should be used. It is a part of OpenShift instance configuration managed by admins or I missed something? |
@akorneta when you claim a persistent volume, you ask for characteristics https://docs.openshift.com/enterprise/3.0/architecture/additional_concepts/storage.html#persistent-volume-claims so maybe you want to be able to choose options of the PV claim. |
It is not even that advanced. Some PVCs are slow for small writes but optimized for larger writes. I think we should have the option disable persistent volume storing in case we see that it affects the performance of the IDE. |
Current implementation of
@gorkem But then we may lose changes of projects sources after workspace restart or crash. I think it is not good UX. Do you think it is acceptable? |
It is not good UX but I was thinking of it as a fallback if PV starts to render IDE unusable. |
@gorkem ok it makes sense I'll add appropriate config property |
Not to lose local changes in sources of projects after workspace restarting we should use persistent volumes for storing sources of projects.
The text was updated successfully, but these errors were encountered: