Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move docker container settings applying from DockerMachineStarter #5871

Closed
garagatyi opened this issue Aug 2, 2017 · 0 comments
Closed

Move docker container settings applying from DockerMachineStarter #5871

garagatyi opened this issue Aug 2, 2017 · 0 comments
Assignees
@garagatyi
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. target/branch Indicates that a PR will be merged into a branch other than master.

Comments

@garagatyi
Copy link

Related to SPI branch only.

DockerMachineStarter class is old and big and it doesn't follow single responsibility principle. Because of this, it is hard to write tests to it as part of this issue.
We need to refactor it and cover its functionality with tests.
I suggest moving all docker system settings from this class to InfrastructureProvider class impl.
I also suggest that it can be split into several components for work with networks, images, containers.
@garagatyi garagatyi added kind/task Internal things, technical debt, and to-do tasks to be performed. target/branch Indicates that a PR will be merged into a branch other than master. team/platform labels Aug 2, 2017
@garagatyi garagatyi self-assigned this Aug 2, 2017
@akorneta akorneta mentioned this issue Aug 2, 2017
Closed
9 tasks
@gazarenkov gazarenkov mentioned this issue Aug 3, 2017
Closed
14 tasks
@garagatyi garagatyi changed the title Refactor DockerMachineStarter Move docker container settings applying from DockerMachineStarter Aug 4, 2017
@garagatyi garagatyi mentioned this issue Aug 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garagatyi garagatyi

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@garagatyi