Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenShift infrastructure doesn't work on Minishift because of dependency on Docker runtime #6085

Closed
garagatyi opened this issue Aug 23, 2017 · 4 comments
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@garagatyi
Copy link

Related to SPI branch only.
In SPI branch both OpenShift and Docker infrastructures are working.
On MiniShift Docker infra tries to reach Docker API and fails.
This prevents us from testing OpenShift infrastructure on MiniShift.
So, we need some way to Disable Docker infrastructure in this case. Probably, it should be done by some property.
Note that it is supposed to be a temporary solution until we realize the proper way to fix it.

@garagatyi garagatyi added kind/bug Outline of a bug - must adhere to the bug report template. team/platform labels Aug 23, 2017
@ibuziuk
Copy link
Member

ibuziuk commented Aug 23, 2017

@garagatyi why do we really need to have both OpenShiftft & Docker infrastructures working simultaneously (is there real usecase for this) ? Could we just have some property for choosing infra when che-server is starting

@garagatyi
Copy link
Author

It is exactly what supposed to be done by this issue

@ibuziuk
Copy link
Member

ibuziuk commented Aug 23, 2017

@garagatyi thanks for clarifications. I was just a bit baffled with the following note:

Note that it is supposed to be a temporary solution until we realize the proper way to fix it.

Was wondering why it is not good enough for the long running solution (not sure that there is a use case where both OpenShiftft & Docker infrastructures need to be working simultaneously)

@gazarenkov
Copy link
Contributor

My vision is that it is a right solution.

On a framework level we should be ready to assembly/test/deploy different assembly.
I.e. it is normal when Che have separated Openshift and Docker and many other assemblies, of course they will have different level of support.
Current project structure and tooling/procedure for making necessary assembly/packaging is probably not good enough for the time for this purpose, let's think about it.

So, my conclusion - having separated Openshift and Docker assembly is normal.
Even if SPI provides ability to make multi-infra assembly I can not find any real-life usecase to keep them both in one.

@skabashnyuk skabashnyuk added kind/task Internal things, technical debt, and to-do tasks to be performed. and removed kind/bug Outline of a bug - must adhere to the bug report template. labels Sep 4, 2017
@garagatyi garagatyi self-assigned this Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

4 participants