Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement supporting of compose based recipes by OpenShift infrastructure #7860

Closed
sleshchenko opened this issue Dec 13, 2017 · 12 comments
Closed
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.

Comments

@sleshchenko
Copy link
Member

Description

Implement supporting of compose based recipes by OpenShift infrastructure.

@sleshchenko sleshchenko added kind/task Internal things, technical debt, and to-do tasks to be performed. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. target/che6 labels Dec 13, 2017
@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Jan 19, 2018

It makes it impossible to create workspace of Java-MySQL types
screenshot from 2018-01-19 11-33-51

@garagatyi
Copy link

@dmytro-ndp yes, it is expected for the time being.

@skabashnyuk
Copy link
Contributor

@l0rd @ibuziuk is there any plans for this issue?

@l0rd
Copy link
Contributor

l0rd commented Sep 10, 2018

I think we can leave without it until Che 7 (ws.next). @slemeur what do you think?

@slemeur
Copy link
Contributor

slemeur commented Sep 10, 2018

agreed for the time being.

@garagatyi
Copy link

In case someone wants to contribute it here are a couple of tips:
Here is an example of a converter that converts one environment into another https://github.com/eclipse/che/blob/master/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/environment/convert/DockerImageEnvironmentConverter.java
This is a very simple one, a converter of compose would be more complex because compose recipe contains a lot of syntax constructs.
Here is an example of a compose converter https://github.com/eclipse/che/blob/master/infrastructures/docker/infrastructure/src/main/java/org/eclipse/che/workspace/infrastructure/docker/environment/convert/ComposeEnvironmentConverter.java
It shows pretty well how it can be implemented on the k8s infra.
After implementing such a converter it is needed to apply it, so here is a place and an example where/how to do it https://github.com/eclipse/che/blob/master/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/KubernetesInfrastructure.java#L76

This is it. I hope it would be enough to implement such a feature. If not, do not hesitate to ask me for more details.

@tgrall
Copy link

tgrall commented Oct 16, 2018

agreed for the time being.

If this is not working why not hiding this option until it works?

@garagatyi
Copy link

We can hide it. But not sure which part should do that. API can avoid returning is, but I'm not sure we need this behavior. The client can skip it. Or client can ask for only supported ones from the API.
On the other hand, stacks might not make sense in Che 7, so we can avoid investing in that.

@skabashnyuk
Copy link
Contributor

@l0rd is this issue still relevant for Che7?

@l0rd
Copy link
Contributor

l0rd commented Mar 6, 2019

I guess this is still relevant. @slemeur?

@slemeur slemeur removed ide6 labels Jul 1, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Aug 30, 2019

@gorkem @slemeur any plans to invest into this or can we close this one?

@che-bot
Copy link
Contributor

che-bot commented Feb 27, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 27, 2020
@che-bot che-bot closed this as completed Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.
Projects
None yet
Development

No branches or pull requests

9 participants