Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LS configuration doc and examples #7869

Closed
gazarenkov opened this issue Dec 14, 2017 · 9 comments
Closed

LS configuration doc and examples #7869

gazarenkov opened this issue Dec 14, 2017 · 9 comments
Assignees
Labels
area/doc Issues related to documentation

Comments

@gazarenkov
Copy link
Contributor

Finalization of #7840

Prepare documentation (with description from PR above) about how to configure and examples:

  • like you provided (but please clean it up from unnecessary config like petclinic db :) )
  • w/o installers, using pre-configured images for both machines (@eivantsov please help)
  • same as second but on OpenShift (with OS recipe)
@ghost
Copy link

ghost commented Dec 14, 2017

@gazarenkov we need #7790

This is the only thing that prevents me from writing these docs right now.

Also, I have an additional question: is this a way to add new LS? So, our existing language servers will be delivered the old fashioned way? This also impacts how docs will look like.

An additional thing to mention.

Currently, the only way to create such a workspace is using REST API - Dashboard lacks a few things:

  1. Cannot provide attributes to servers
  2. There's no way to create workspaces from custom OpenShift recipes on OpenShift.

@gazarenkov
Copy link
Contributor Author

@eivantsov cool, feel free to assign it to yourself then :)

Well, I would consider to get rid of additional LS server specific extensions to be deployed near LS Registry. It adds extra-actions to dev and reduces plugability of LSes(we started this discussion with @vparfonov, @dkuleshov and @evidolob and have kinda agreement).
If it is what you had in mind than I'd answer let's remove "old fashioned way".
WDYT?

@gorkem
Copy link
Contributor

gorkem commented Dec 15, 2017

The current level of configuration that needs to be put for bringing in a language server is not acceptable. I would solve that problem first before documenting it

@ghost
Copy link

ghost commented Dec 16, 2017

@gorkem can you be more specific on what needs to be solved first? In this issue #7790 we are trying to achieve some state when adding a language server means adding a machine with a declared server with a particular set of attributes where path regexp is defined (basically for what files to initialize a language server). This is the POC that we want to finalize and document.

@gorkem
Copy link
Contributor

gorkem commented Dec 16, 2017

Depends on what kind of document, I guess. If it is user document than it becomes a user concept that needs to be supported in the future. We can not keep breaking user's setup. At this state defining a LS is not as easy as it used to be.

@vparfonov
Copy link
Contributor

Maybe we miss something. We will not require manual configuration for new LS, this is just option and description how it's works. I think we can provide same behavior like we have now, user during creation WS just select some checkboks and we add needing config to the WS.

@ghost
Copy link

ghost commented Dec 18, 2017

It's about how we handle it in User Dashboard. So, nothing changes for existing Language Servers. As to adding new ones, it will be way easier than it is now when you have to rebuild the entire project.

@gorkem
Copy link
Contributor

gorkem commented Dec 18, 2017

Dashboard is not the only way to define language servers to a workspace. I want to ensure that the configuration that we would have to expose through things like factories or chefile etc is also easy.

@ghost
Copy link

ghost commented Jul 2, 2018

@ghost ghost closed this as completed Jul 2, 2018
@benoitf benoitf added area/doc Issues related to documentation and removed kind/docs labels Jul 9, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/doc Issues related to documentation
Projects
None yet
Development

No branches or pull requests

5 participants