Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to use host-based routing instead of path-based for k8s infra #8694

Closed
sleshchenko opened this issue Feb 9, 2018 · 5 comments · Fixed by #9329
Closed

Add an ability to use host-based routing instead of path-based for k8s infra #8694

sleshchenko opened this issue Feb 9, 2018 · 5 comments · Fixed by #9329
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.

Comments

@sleshchenko
Copy link
Member

Description

Many applications expect to be the only one application deployed on a host. And they may use absolute links. In case of using path-based routing, such applications will be broken.
An example of it is che-samples/web-java-spring.
There is the main page that redirects users to spring/hello page. But in case of host-based routing, it doesn't work.

See screencase how it works

web-spring-k8s

So it is needed to investigate host-based routing for k8s-infra and add it as an option or replace current path-based routing.

@sleshchenko sleshchenko added kind/enhancement A feature request - must adhere to the feature request template. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/platform labels Feb 9, 2018
@ghost
Copy link

ghost commented Mar 15, 2018

This makes dev flow on k8s almost impossible

@skabashnyuk
Copy link
Contributor

@eivantsov what do you mean?

@riuvshin
Copy link
Contributor

@skabashnyuk have you seen attached screencast? it is not possible to access your application started in a WS to check your changes and even debug it.

@skabashnyuk
Copy link
Contributor

@riuvshin understood

@ghost
Copy link

ghost commented Apr 5, 2018

Looks like @guydaichs's PR fixes this one. Worked for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants