Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show dialog window to open Theia Hosted Instance in case browser blocks opening of a new tab #9644

Closed
olexii4 opened this issue May 8, 2018 · 3 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template.

Comments

@olexii4
Copy link
Contributor

olexii4 commented May 8, 2018

Description

Hosted plugin manager for https://github.com/theia-demo-plugins/wiptheia doesn't start a plugin instance. And styles of select path window should be more readable.
selection_006

Reproduction Steps

  1. Open wiptheia and select path a plugin instance.
    selection_007
  2. Start instanse.
    selection_008
  3. Open a new page with the needed link. And there is no the checked plugin.
    In the case of env HOSTED_PLUGIN all is OK.
@ashumilova ashumilova added kind/bug Outline of a bug - must adhere to the bug report template. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/ide2 sprint/next labels May 8, 2018
@mmorhun mmorhun self-assigned this May 30, 2018
@mmorhun
Copy link
Contributor

mmorhun commented May 31, 2018

@olexii4 you can see the problem from the second screenshot. Your browser blocks popup. Allow them or open the url manually

@mmorhun
Copy link
Contributor

mmorhun commented May 31, 2018

So @olexii4 gives an idea to improve IDE behaviour in case popups is blocked. So we can add dialog with link to click to open a new tab with hosted instance.

@mmorhun mmorhun reopened this May 31, 2018
@mmorhun mmorhun added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Jun 4, 2018
@mmorhun mmorhun changed the title Hosted plugin manager for wiptheia doesn't start a plugin instance. Show dialog window to open Theia Hosted Instance in case browser blocks opening of a new tab Jun 6, 2018
@mmorhun
Copy link
Contributor

mmorhun commented Jun 6, 2018

Done for popup. Styles is outside this issue.

@mmorhun mmorhun closed this as completed Jun 6, 2018
@ashumilova ashumilova removed sprint/current status/in-progress This issue has been taken by an engineer and is under active development. labels Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

No branches or pull requests

3 participants