Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent syntax highlighting in light theme #2430

Open
FilipDrabek-Broadcom opened this issue Aug 12, 2024 · 3 comments
Open

Inconsistent syntax highlighting in light theme #2430

FilipDrabek-Broadcom opened this issue Aug 12, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@FilipDrabek-Broadcom
Copy link

Syntax highlighting is inconsistent when changing (from dark theme) to light theme.
image
The brackets are no longer yellow color in light theme.

@FilipDrabek-Broadcom FilipDrabek-Broadcom added the bug Something isn't working label Aug 12, 2024
@ap891843
Copy link
Contributor

I did see similar behavior for other languages as well (for e.g. JS). Which makes me believe it might be related to theme.
This could be something to investigate.

image
image

@FilipDrabek-Broadcom
Copy link
Author

I just checked it myself and it looks like the color of the brackets is still slightly different to the color of the "name". Although from the user experience perspective, I would expect totally different color (as is case with Dark Theme).
image
image

Difference in hues.
image

But in our case the colors are either the same or almost indistinguishable.
image

Difference in hues.
image

@FilipDrabek-Broadcom
Copy link
Author

Again, I think we should stay consistent with VS Code standard.

Please use colors as per the "javascript" example.
image
image

Unfortunately I don't have the CSS file, so I don't know the exact HEX value, but the colors should look like these two hues.
image

@github-project-automation github-project-automation bot moved this to Needs triage in Defects board Sep 9, 2024
@ishche ishche moved this from Needs triage to To investigate in Defects board Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To investigate
Development

No branches or pull requests

2 participants