feat: AREAD support #125
Merged
feat: AREAD support #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
slavek-kucera
commented
May 6, 2021
| finished_flag = true; | ||
| input_tokens_invalidated = true; | ||
|
|
||
| if (!line.empty()) |
There was a problem hiding this comment.
should we do pseudo-ascii conversion here?
|
|
||
| const auto& record = dynamic_cast<const semantics::string_assembler_operand&>(*ops.value[0]).value; | ||
| AINSERT_operand_visitor visitor; | ||
| dynamic_cast<const semantics::expr_assembler_operand&>(*ops.value[1]).expression->apply(visitor); |
There was a problem hiding this comment.
Would it be enough to just dynamic_cast the machine expression to expressions::mach_expr_symbol and get the value from there? Seems easier than defining a visitor.
| && ops.value[1]->type == semantics::operand_type::EMPTY) | ||
| return aread_variant::reader; | ||
|
|
||
| AREAD_operand_visitor op(&eval_ctx); |
There was a problem hiding this comment.
same thing here? dynamic_cast to semantics::expr_ca_operand?
|
Kudos, SonarCloud Quality Gate passed! |
michalbali256
approved these changes
May 14, 2021
|
🎉 This PR is included in version 0.13.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AREAD/AINSERT support.