Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ghproxy in deployment #274

Closed
netomi opened this issue Sep 18, 2024 · 2 comments · Fixed by #280
Closed

Use ghproxy in deployment #274

netomi opened this issue Sep 18, 2024 · 2 comments · Fixed by #280
Assignees

Comments

@netomi
Copy link
Contributor

netomi commented Sep 18, 2024

To avoid hitting secondary rate limits when accessing the GitHub API from different services within the cluster: https://docs.prow.k8s.io/docs/ghproxy/

@netomi
Copy link
Contributor Author

netomi commented Sep 20, 2024

Created kubernetes-sigs/prow#280 to fix a few small minor things.

I could already integrate ghproxy into otterdog and it works pretty neat.

@netomi netomi self-assigned this Sep 20, 2024
@netomi
Copy link
Contributor Author

netomi commented Sep 20, 2024

The additional throttling mechanism to prevent hitting secondary rate limits is not exactly what we would need / want.

It lets you specify how much time must pass between individual requests, e.g. 100ms, so does not take into account the potential cost of a query.

Putting the delay too high will result in quite slow processing as we need to do a lot of requests when retrieving the current live configuration of an organization. Too low values might still result in secondary rate limits issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant