Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag redundant settings #45

Closed
eclipse-csi-bot opened this issue May 26, 2023 · 2 comments
Closed

Flag redundant settings #45

eclipse-csi-bot opened this issue May 26, 2023 · 2 comments

Comments

@eclipse-csi-bot
Copy link
Contributor

In GitLab by @netomi on May 26, 2023, 13:48

Currently, it is not obvious to a user, if a setting is already inherited from the default configuration and thus can be omitted.

Example:

orgs.newBranchProtectionRule('main') {
  allows_deletions: false
},

if allows_deletions is already defined like that in the default config, specifying it again is redundant.

Ideally we should flag redundant settings during validation.
However, this is not trivial, as otterdog processes the resulting json which has no resemblance anymore with the original config.

A solution could be to export the json again to jsonnet and diff it with the original config which should outline unnecessary settings.

@eclipse-csi-bot
Copy link
Contributor Author

In GitLab by @netomi on May 26, 2023, 15:26

mentioned in commit 37115ee

@eclipse-csi-bot
Copy link
Contributor Author

In GitLab by @netomi on May 26, 2023, 15:26

implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant