Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Asset from ContractOffer and replace with a reference #2889

Closed
jimmarino opened this issue May 6, 2023 · 0 comments · Fixed by #2896
Closed

Remove Asset from ContractOffer and replace with a reference #2889

jimmarino opened this issue May 6, 2023 · 0 comments · Fixed by #2896
Assignees
@jimmarino
Labels
core feature
Milestone
Milestone 9

Comments

@jimmarino
Copy link
Contributor

org.eclipse.edc.connector.contract.spi.types.offer.ContractOffer was made to contain a direct reference to an Asset in order to accommodate the old IDS protocol which overloaded ContractOffer to be the equivalent of a catalog dataset and an offer.

The DSP protocol has removed this overloading and introduced DCAT Datasets for expressing assets that contain ODRL Policys. The EDC ContractOffer should not contain the Asset representation and instead only reference it by id.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimmarino jimmarino

Labels
core feature
Projects
None yet
Milestone
Milestone 9
Development

Successfully merging a pull request may close this issue.

chore: remove Asset from ContractOffer and replace with an id reference jimmarino/DataSpaceConnector
1 participant
@jimmarino