Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in EDC 0.7.7 concerning AWS objectName/folderName when executing /v3/transferprocesses #501

Open
magnabschaller opened this issue Dec 18, 2024 · 6 comments

Comments

@magnabschaller
Copy link

Bug Report

Specified AWS properties folderName & objectName in DataDestination properties for v3/transferprocesses

still original foldername from provider and original filename from provider is being taken (no overwrite possible)

Postman
image

S3 Bucket
image

Expected Behavior

expecting as in EDC 0.5.3 that foldername and object name are overwritten based on API properties

Observed Behavior

original filename & foldername have been used instead (original from data provider, not as specified as consumer)

Steps to Reproduce

Steps to reproduce the behavior:

  1. Query Catalog of your partner
  2. execute contract negotiation
  3. initiate transfer for transferprocess ID with AWS properties as above in screenshot
  4. See error inside AWS (wrong folder, wrong filename)

Context Information

Add any other context about the problem here.

  • EDC 0.7.7
@github-actions github-actions bot added the triage all new issues awaiting classification label Dec 18, 2024
Copy link

Thanks for your contribution 🔥 We will take a look asap 🚀

@ndr-brt
Copy link
Member

ndr-brt commented Dec 18, 2024

Seeing the version number I imagine you are referring to Tractus-X EDC, please open the issue in the correct repository:
https://github.com/eclipse-tractusx/tractusx-edc

@ndr-brt ndr-brt removed the triage all new issues awaiting classification label Dec 18, 2024
@rafaelmag110
Copy link
Contributor

The mentioned version is indeed wrong and doesn't belong to the EDC project but rather tractus-edc.

However, the content of the issue seems to be in the correct place and if there is an error in the way the foldername/objectname attributes are being used this is the place to solve them...

@gerbigf
Copy link

gerbigf commented Dec 18, 2024

I was involved in the transfer in question. They are indeed using a Tractus-X EDC 0.7.7, but I've checked and there weren't any contributions to the s3 data plane extension that could have fixed the behaviour in one of the newer versions since 0.7.7. So I assume the issue is still valid.

@rafaelmag110
Copy link
Contributor

tractusx-edc 0.7.7 uses eclipse-edc/technology-AWS v0.7.2. That's an important distinction that needs to be made since the upstream project is not aware of downstream versions.
The issue should be updated with that version.

@ndr-brt
Copy link
Member

ndr-brt commented Dec 18, 2024

The issue is valid if it affects EDC 0.10.x version or the main branch.
If a fix is needed in T-X EDC 0.7.7, the issue needs to be opened downstream and tackled separately (because EDC version 0.7.2 that's used in T-X EDC 0.7.7 is not maintained anymore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants