Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excessive code duplication in components code #1391

Open
romain-grecourt opened this issue May 8, 2019 · 0 comments
Open

Remove excessive code duplication in components code #1391

romain-grecourt opened this issue May 8, 2019 · 0 comments

Comments

@romain-grecourt
Copy link
Member

romain-grecourt commented May 8, 2019

The components code is full of duplicated code and Javadocs for the various attributes.
Some common attributes are found in many components (.e.g visible, onClick, onMouseOver, onMouseOut, style, styleClass etc) and the corresponding code and Javadocs is repeated in every single component class.

There is already a lot of code generation happening for the tag lib descriptor file, the Tag classes, and the faces-config XML ; it should be feasible to extend the annotation framework in order to improve the component definition to share the common component attributes definition and automate the corresponding code (e.g. saveState and restoreState methods).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant