Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta EE 8: Release JAX-RS 2.1.1 #638

Closed
mkarg opened this issue Jul 21, 2018 · 38 comments
Closed

Jakarta EE 8: Release JAX-RS 2.1.1 #638

mkarg opened this issue Jul 21, 2018 · 38 comments
Assignees
Labels
Milestone

Comments

@mkarg
Copy link
Contributor

mkarg commented Jul 21, 2018

The Eclipse Foundation aims to provide a common Jakarta EE 8 release, which means we should release JAX-RS 2.1.1 (i. e. more or less JAX-RS 2.1 + EPL + Essential Bug Fixes + our share of the TCK, hence content of our repo's EE4J_8 branch).

This issue serves as a place for planning and performing that release.

Issues for this particular release can be found here: https://github.com/eclipse-ee4j/jaxrs-api/milestone/7.

@mkarg
Copy link
Contributor Author

mkarg commented Jul 21, 2018

Is somebody already preparing this?

@mkarg mkarg added this to the 2.2.1 milestone Jul 21, 2018
@mkarg mkarg added the project label Jul 21, 2018
@spericas
Copy link
Contributor

@mkarg Yes, I can work on this one. I will be running signature tests with the TCKs to make sure we can release this.

@mkarg
Copy link
Contributor Author

mkarg commented Jul 23, 2018

@spericas Great! Thanks! :-)

@mkarg
Copy link
Contributor Author

mkarg commented Jul 25, 2018

@spericas I have prepared nightly builds (see #643) on EF infrastructure, just in case you're ready to commit the TCK. :-)

@spericas
Copy link
Contributor

@mkarg :-) Thanks, I will take a look.

@mkarg
Copy link
Contributor Author

mkarg commented Aug 15, 2018

Now that we have nightly builds in EF Nexus and the release pipeline in OSSRH set up, what is open wrt the release? TCK? Spec? Bug collections? What shall people help with?

@spericas
Copy link
Contributor

@mkarg With the help of @jansupol it was verified that 2.1.1-SNAPSHOT passes the TCKs. I think we should drop SNAPSHOT via a PR and start with the voting to push 2.1.1 to OSSRH (unless I'm missing some other step).

@mkarg
Copy link
Contributor Author

mkarg commented Aug 15, 2018

@spericas Sounds good, but can we wait with this final PR until the weekend? I'd like to add some of the bug fixes we merged into 2.2-SNAPSHOT. I would send you a list with the commit IDs so you can add them to your PR. Or did you already do that (I did not find any in the EE4J branch)?

@spericas
Copy link
Contributor

@mkarg I thought we had merged those when deleting 2.1.1-SNAPSHOT, but I guess they were not there. Yes, let's get those in and prepare the branch to kick off the release. I'll look for those commit IDs, but if you have them handy please paste them here.

@spericas
Copy link
Contributor

I believe these are the two commits:

c8e9d18
4880f9c

Agreed?

@mkarg
Copy link
Contributor Author

mkarg commented Aug 16, 2018

We could possibly merge more. What about adding these, too?

82496b3
a292276
a046a50
e781b33
5afcef5
50cab0b

@spericas
Copy link
Contributor

@mkarg I have the last two ready in my fork. The other ones are OK except for e781b33 since I believe there was some discrepancy in the implementations and moving from 2.1 to 2.1.1 should require no changes IMO.

@mkarg
Copy link
Contributor Author

mkarg commented Aug 16, 2018

@spericas Agreed, let's keep e781 out. Ok, so after few cherry-picks on your side we're ready to release, right? What about that EF release review stuff, is that ready or shall I prepare something?

@spericas
Copy link
Contributor

@mkarg The commit message for this one:

82496b3

mentions version 2.2. I sort of understand why and would suggest that we leave it out as well for 2.1.1. Other than that, the PR is ready on my end.

@mkarg
Copy link
Contributor Author

mkarg commented Aug 17, 2018

That was a typo. Actually it should read "According to JAX-RS 2.1 specification". So we could add it to 2.1.1.

@spericas
Copy link
Contributor

@mkarg Ok, PR has been submitted.

@mkarg
Copy link
Contributor Author

mkarg commented Aug 24, 2018

Release staged on OSSRH and passed validation: https://ci.eclipse.org/jaxrs/job/Publish%20Release/11/.
Next step is IP Approval and Release Review, according to https://docs.google.com/drawings/d/1ZoEf7lvzBOB1PIq7q7JdFbTvTlAgzCkvIiEDH-CYJL4/edit.

@spericas
Copy link
Contributor

@mkarg My understanding is that we are on step 6 here:

https://github.com/eclipse-ee4j/ee4j/wiki/How-to-release-the-first-Eclipse-version-of-projects

So just need to kick off a new release on our project page. I'm confused about the IP Approval that you mentioned. What is that?

@mkarg
Copy link
Contributor Author

mkarg commented Aug 25, 2018

@spericas I assume the term "IP Approval" found in the chart means step 9 in Dmiry's list.

@mkarg
Copy link
Contributor Author

mkarg commented Aug 27, 2018

@spericas If you want I can do the EF paperwork, but for that, we apparently need to agree upon an official release date first (I think this is due to legal issues). I propose 2018-09-10 for 2.1.1. Then the papaperwork is:

  1. Submit Release announcement here https://projects.eclipse.org/node/12849/create-release
  2. Submit IP Log review request here https://projects.eclipse.org/projects/ee4j.jaxrs/iplog/preview
  3. Request PMC Release review here https://dev.eclipse.org/mailman/listinfo/ee4j-pmc

IIUC that should be all. Shall I do it or are your doing it?

@spericas
Copy link
Contributor

@mkarg I'm OK with the proposed release date. I'll go ahead with step (1) and then we can coordinate the others.

@mkarg
Copy link
Contributor Author

mkarg commented Aug 27, 2018

@spericas Ok, just ping me when I shall do something.

@spericas
Copy link
Contributor

https://projects.eclipse.org/projects/ee4j.jaxrs/releases/2.1.1

@mkarg Do you have full access to view and edit the release?

@mkarg
Copy link
Contributor Author

mkarg commented Aug 27, 2018

@spericas Yes, I could press "Save" (without changing anything) and it says "Updated release".

@spericas
Copy link
Contributor

@mkarg Great, I filled out some basic info about the release now. If you want to start with (2) and (3) from your list, go ahead. Otherwise, I'll get back to this later.

@mkarg
Copy link
Contributor Author

mkarg commented Aug 27, 2018

@spericas Okay I will do (2) and (3).

@mkarg
Copy link
Contributor Author

mkarg commented Aug 27, 2018

@mkarg
Copy link
Contributor Author

mkarg commented Aug 27, 2018

@mkarg
Copy link
Contributor Author

mkarg commented Aug 28, 2018

@spericas (2) IP log is approved. http://dev.eclipse.org/ipzilla/show_bug.cgi?id=17366

@mkarg
Copy link
Contributor Author

mkarg commented Aug 30, 2018

@spericas (3) PMC has approved release 2.1.1. Still waiting for EMO approval (review still is in pending state)

@mkarg
Copy link
Contributor Author

mkarg commented Sep 6, 2018

@spericas (3) EF release review is successfully finished since yesterday (https://bugs.eclipse.org/bugs/show_bug.cgi?id=538340), so as announces I will technically release JAX-RS 2.1.1 to Maven Central on 2018-09-10. If you know any showstoppers then please let me know, otherwise this is the point of no return, as we cannot remove or update artifacts on Maven Central.

@spericas
Copy link
Contributor

spericas commented Sep 6, 2018

@mkarg No showstoppers that I know, green light!

@mkarg
Copy link
Contributor Author

mkarg commented Sep 8, 2018

@spericas Pressed the button. It will take a while to sync. Should be available at The Central Repository on Monday (or even on Sunday).

@mkarg
Copy link
Contributor Author

mkarg commented Sep 8, 2018

@spericas Wow, sync was pretty fast: Building Jersey mvn tells me Downloaded from central: https://repo.maven.apache.org/maven2/javax/ws/rs/javax.ws.rs-api/2.1.1/javax.ws.rs-api-2.1.1.jar (127 kB at 220 kB/s)!

Closing this issue with your kind permission, as this proofs we just successfully published our first release!

@mkarg mkarg closed this as completed Sep 8, 2018
@chkal
Copy link
Contributor

chkal commented Sep 9, 2018

Awesome! Thanks @mkarg!

BTW: AFAIK the sync to Maven central only takes about one hour. But the update of the search index on search.maven.org takes much longer.

@mkarg
Copy link
Contributor Author

mkarg commented Sep 9, 2018 via email

@spericas
Copy link
Contributor

Awesome, great job!

@mkarg
Copy link
Contributor Author

mkarg commented Sep 12, 2018

Tagged as "2.1.1" so it shows up in Github "Releases" view now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants