memory leak in multipart uploads

[jerseyrobot]

Requests with multipart uploads create temp files (MIMExxx.tmp) which are marked for deletion using the JVM hook deleteOnExit. For long-running server processes, this is not appropriate since it leads to a memory leak (tracking of an ever-increasing number of references in a LinkedHashSet in java.io.DeleteOnExitHook).

See related mimepull issue: https://java.net/jira/browse/MIMEPULL-13

Affected Versions

[2.21]

[jerseyrobot]

@glassfishrobot Commented
Reported by phraktle2

[jerseyrobot]

@glassfishrobot Commented
phraktle2 said:
Any plans on fixing this? This affects long running server-apps, resulting in OOM.

[jerseyrobot]

@glassfishrobot Commented
phraktle2 said:
This is still a problem.

[jerseyrobot]

@glassfishrobot Commented
This issue was imported from java.net JIRA JERSEY-2987

[jerseyrobot]

• Issue Imported From: https://github.com/jersey/jersey/issues/3259
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @mpotociar

[gopi-gith]

Due to this bug, we are forced to move away from using MultiPart. We refactored our APIs to use non-multipart requests. Is there a way to upvote this bug?

[essobedo]

FYI, this bug seems to be fixed thanks to eclipse-ee4j/metro-mimepull#13 that is included in mimepull 1.9.13 and that is now the version used in the master branch of jersey thanks to this commit 950ce6c#diff-600376dffeb79835ede4a0b285078036
However so far there is no release of Jersey that includes this upgrade so If you need a fix, you will have to force the version of mimepull to 1.9.13 in your project which I did and it seems to work well.

[averigin]

It looks like mimepull was updated to 1.9.13 in #4425 which was released as part of v2.31.

However, it still seems that multipart requests with files end up generating delete-on-exit hooks. FormDataParamValueParamProvider$FileProvider still calls Utils.createTempFile(), which calls File.deleteOnExit().

[averigin]

I finally had time to revisit this.

In my endpoint definition, I switched from using a File to an InputStream. From what I can tell in FormDataParamValueParamProvider.java, this generates a FormDataParamValueProvider instead of a FileProvider, so it bypasses the Utils.createTempFile() call. Thus, my endpoint no longer generates delete-on-exit hooks for every request.

I still think this is a work-around and not a proper solution, but I'm posting it in the hopes that it helps someone else.