Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.1.0-M2 #4941

Closed
arjantijms opened this issue Dec 19, 2021 · 9 comments · Fixed by #4942
Closed

Release 3.1.0-M2 #4941

arjantijms opened this issue Dec 19, 2021 · 9 comments · Fixed by #4942
Milestone

Comments

@arjantijms
Copy link
Contributor

Hi,

The current release of 3.1, M1, unfortunately doesn't work for GlassFish 7 and/or CDI 4 environments at all. It's only a few commits that are missing, but they are absolutely critical.

Shall we stage an M2?

I can do this myself.

@arjantijms arjantijms added this to the 3.1.0 milestone Dec 19, 2021
@senivam
Copy link
Contributor

senivam commented Dec 20, 2021

Hi Arjan,

we will release the M2 shortly. There is a separate job for the 3.1.x releases.

@arjantijms
Copy link
Contributor Author

Thanks @senivam

Btw, this job can probably be updated to JDK 17 now:
https://ci.eclipse.org/jersey/job/continuous-integration/job/3.1/

@senivam
Copy link
Contributor

senivam commented Dec 20, 2021

regarding build update to JDK 17 there is an issue related to maven 3.8.3, nexus-staging-maven-plugin which requires as workaround setting of JDK_JAVA_OPTIONS or MAVEN_OPTS to --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang.reflect=ALL-UNNAMED --add-opens java.base/java.text=ALL-UNNAMED --add-opens java.desktop/java.awt.font=ALL-UNNAMED

so as soon as we still have everything targeted to JDK 11 and for now release perfectly works on JDK 11.0.2 I would keep that configuration until some fixes are released for indicated maven/nexus-staging-maven-plugin combination.

just for reference, the mentioned bug is listed at Sonatype as NEXUS-27902

@arjantijms
Copy link
Contributor Author

@senivam I see, though Jenkins I think I still running Maven 3.6.0 or so. At least for GlassFish we're able to build with JDK 17. See https://ci.eclipse.org/glassfish/view/GlassFish/job/glassfish_build-and-test_jdk17/

The importance to test/build on JDK 17 as well, is that Jakarta EE 10 promises (more or less) compatibility with JDK 17.

@senivam senivam linked a pull request Dec 20, 2021 that will close this issue
@senivam
Copy link
Contributor

senivam commented Dec 20, 2021

Sorry Arjan, I've got it wrong :) I thought we are talking about the release but for sure CI/CD build job shall be upgraded to perform builds on JDK17. Please take a look to the linked PR. Thanks :)

@jansupol
Copy link
Contributor

The main JDK version for Jakarta EE 10 is JDK 11. We should be certain that Jersey works well on JDK 17, but the main testing should be on JDK 11.

@arjantijms
Copy link
Contributor Author

@jansupol indeed, agreed!

@jansupol
Copy link
Contributor

@arjantijms Jersey 3.1.0-M2 is in staging.

@arjantijms
Copy link
Contributor Author

@jansupol Thanks! I'll update the GF PR to it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants