-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redact HTTP headers on LoggingFeature #5014
Milestone
Comments
nunomsantos
changed the title
Redact HTTP headers on LoggingFilter
Redact HTTP headers on LoggingFeature
Mar 25, 2022
It could be useful. Feel free to provide a PR. Thanks. |
I think yes, it was not linked to the PR to be closed automatically, so it was just forgotten. Thanks for reminding. |
This was referenced Jun 14, 2022
Closed
1 task
This was referenced Jun 18, 2022
This was referenced Dec 7, 2022
Closed
1 task
This was referenced Jan 6, 2023
Merged
This was referenced Feb 11, 2023
Closed
1 task
This was referenced May 11, 2023
This was referenced Jun 1, 2023
This was referenced Jun 4, 2023
This was referenced Jun 15, 2023
This was referenced Jul 6, 2023
This was referenced Aug 28, 2023
This was referenced Jan 16, 2024
1 task
This was referenced Apr 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi all,
Currently,
LoggingFeature
logs all HTTP headers of requests and responses. This might write sensitive data to the logs, like the Authorization header.I was thinking of adding a configurable denylist of HTTP headers where one could specify, e.g., a comma separated list of headers whose value should be redacted before logging the request or response. We could also have a reasonable default denylist - does anyone know of other standard headers with sensitive data?
Would you consider this behavior valuable? I'm available to open a PR with this change if agreed.
The text was updated successfully, but these errors were encountered: