Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redact HTTP headers on LoggingFeature #5014

Closed
nunomsantos opened this issue Mar 25, 2022 · 3 comments
Closed

Redact HTTP headers on LoggingFeature #5014

nunomsantos opened this issue Mar 25, 2022 · 3 comments
Milestone

Comments

@nunomsantos
Copy link
Contributor

nunomsantos commented Mar 25, 2022

Hi all,

Currently, LoggingFeature logs all HTTP headers of requests and responses. This might write sensitive data to the logs, like the Authorization header.
I was thinking of adding a configurable denylist of HTTP headers where one could specify, e.g., a comma separated list of headers whose value should be redacted before logging the request or response. We could also have a reasonable default denylist - does anyone know of other standard headers with sensitive data?

Would you consider this behavior valuable? I'm available to open a PR with this change if agreed.

@nunomsantos nunomsantos changed the title Redact HTTP headers on LoggingFilter Redact HTTP headers on LoggingFeature Mar 25, 2022
@jansupol
Copy link
Contributor

It could be useful. Feel free to provide a PR. Thanks.

@nunomsantos
Copy link
Contributor Author

Hi, @senivam @jansupol. Can we close this issue?

@senivam
Copy link
Contributor

senivam commented May 16, 2022

I think yes, it was not linked to the PR to be closed automatically, so it was just forgotten. Thanks for reminding.

@senivam senivam closed this as completed May 16, 2022
@senivam senivam added this to the 2.36 milestone May 16, 2022
This was referenced Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants