Align Node server validation with Java server (async live validation) #99
+40
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
reviewed
Nov 27, 2024
There was a problem hiding this comment.
In general the changes look good to me.
However, I'm not the biggest fan of pulling in additional libraries just to use one function.
Especially if its something like debounce which we can easily implement ourself.
I would be in favor of replacing the loadash import with a custom debounce function.
|
@tortmayr I agree that pulling in libraries for a single function is not always the best option. However, we already use lodash in the client and in the theia-integration. Do you really think the impact is that large? I'm always a bit worried to re-implement such a common pattern. Note that we can already see the lodash dependency in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
See also eclipse-glsp/glsp-server#247
Fixes eclipse-glsp/glsp#1408
How to test
Follow-ups
Changelog