-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create batch requests for (un)registering command consumers in Command Router (MQTT/AMQP) #3445
Comments
The discussed batch feature has benefit in respect of (API call) optimization but has drawback of client delay. The batch requests will impose delay on the client requests. See #2069 (comment) I think the batch requests have main value during adapter start up when all devices connects and do command subscription. |
Follow-up of #2069:
If a large number of AMQP/MQTT devices get disconnected by an adapter shutdown, the subsequent reconnects to another adapter instance will produce many "registerCommandConsumer" requests to the Command Router (potentially leading to "no credits" errors), which could probably better be done as batch requests.
(Implementation of batch requests had been already started in the abandoned PR #3386.)
It could also be considered creating batch requests for "unregisterCommandConsumer" requests, although the question is whether this is really needed.
The text was updated successfully, but these errors were encountered: